From: David Howells <dhowells@redhat.com>
To: Dan Carpenter <error27@gmail.com>
Cc: dhowells@redhat.com, kernel-janitors@vger.kernel.org,
linux-afs@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [patch] afs: potential null dereference
Date: Mon, 22 Mar 2010 13:05:24 +0000 [thread overview]
Message-ID: <12814.1269263124@redhat.com> (raw)
In-Reply-To: <20100322125626.GM21571@bicker>
Dan Carpenter <error27@gmail.com> wrote:
> I was concerned about the dereference here:
>
> + if (xpermits)
> + memcpy(permits->permits, xpermits->permits,
> ^^^^^^^^^^^^^^^^^
> + count * sizeof(struct afs_permit));
That's a good point - in which case your patch should definitely go in.
David
next prev parent reply other threads:[~2010-03-22 13:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-20 11:19 [patch] afs: potential null dereference Dan Carpenter
2010-03-20 11:19 ` Dan Carpenter
2010-03-22 12:05 ` David Howells
2010-03-22 12:56 ` Dan Carpenter
2010-03-22 12:56 ` Dan Carpenter
2010-03-22 13:05 ` David Howells [this message]
-- strict thread matches above, loose matches on Subject: below --
2010-03-22 13:07 [PATCH] AFS: Potential " David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=12814.1269263124@redhat.com \
--to=dhowells@redhat.com \
--cc=error27@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-afs@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.