From: Marcel Holtmann <marcel@holtmann.org>
To: Mat Martineau <mathewm@codeaurora.org>
Cc: linux-bluetooth@vger.kernel.org, gustavo@padovan.org,
rshaffer@codeaurora.org, linux-arm-msm@vger.kernel.org
Subject: Re: [RFC 4/7] Bluetooth: Linearize received L2CAP skbuffs.
Date: Tue, 10 Aug 2010 17:38:33 -0400 [thread overview]
Message-ID: <1281476313.12579.229.camel@localhost.localdomain> (raw)
In-Reply-To: <1281467704-5378-5-git-send-email-mathewm@codeaurora.org>
Hi Mat,
> Fragmented skbs are only encountered by in-kernel protocols and
> profiles when receiving ERTM or streaming mode L2CAP data. BNEP,
> CMTP, HIDP, and RFCOMM generally use basic mode, so will not
> generally need the extra memcpy's necessary to put the L2CAP
> payload in to a linear buffer. However, it is possible to
> use enhanced L2CAP in these modes so the possibility needs
> to be handled.
>
> Signed-off-by: Mat Martineau <mathewm@codeaurora.org>
> ---
> net/bluetooth/bnep/core.c | 5 ++++-
> net/bluetooth/cmtp/core.c | 5 ++++-
> net/bluetooth/hidp/core.c | 10 ++++++++--
> net/bluetooth/rfcomm/core.c | 5 ++++-
> 4 files changed, 20 insertions(+), 5 deletions(-)
in general I am fine with this.
Regards
Marcel
next prev parent reply other threads:[~2010-08-10 21:38 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-10 19:14 [RFC 0/7] L2CAP fragmentation changes Mat Martineau
2010-08-10 19:14 ` [RFC 1/7] Bluetooth: Calculate L2CAP FCS on fragmented skbuffs Mat Martineau
2010-08-10 21:22 ` Marcel Holtmann
2010-08-10 21:57 ` Gustavo F. Padovan
2010-08-10 19:14 ` [RFC 2/7] Bluetooth: Use enhanced L2CAP header structure and symbolic values Mat Martineau
2010-08-10 21:39 ` Marcel Holtmann
2010-08-10 22:07 ` Gustavo F. Padovan
2010-08-11 2:24 ` Mat Martineau
2010-08-11 3:23 ` Gustavo F. Padovan
2010-08-10 19:15 ` [RFC 3/7] Bluetooth: Add FCS awareness to L2CAP HCI fragmentation Mat Martineau
2010-08-10 21:29 ` Marcel Holtmann
2010-08-11 3:35 ` Gustavo F. Padovan
2010-08-11 3:56 ` Gustavo F. Padovan
2010-08-12 23:36 ` Mat Martineau
2010-08-13 15:41 ` Gustavo F. Padovan
2010-08-12 23:26 ` Mat Martineau
2010-08-10 19:15 ` [RFC 4/7] Bluetooth: Linearize received L2CAP skbuffs Mat Martineau
2010-08-10 21:38 ` Marcel Holtmann [this message]
2010-08-11 3:58 ` Gustavo F. Padovan
2010-08-10 19:15 ` [RFC 5/7] Bluetooth: Handle fragmented skbs in bt_sock_stream_recvmsg() Mat Martineau
2010-08-11 4:25 ` Gustavo F. Padovan
2010-08-13 0:07 ` Mat Martineau
2010-08-10 19:15 ` [RFC 6/7] Bluetooth: Reassemble enhanced L2CAP PDUs using skb fragments Mat Martineau
2010-08-11 5:24 ` Gustavo F. Padovan
2010-08-13 0:11 ` Mat Martineau
2010-08-10 19:15 ` [RFC 7/7] Bluetooth: Do not limit enhanced L2CAP max PDU size to HCI MTU Mat Martineau
2010-08-11 5:25 ` Gustavo F. Padovan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1281476313.12579.229.camel@localhost.localdomain \
--to=marcel@holtmann.org \
--cc=gustavo@padovan.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=mathewm@codeaurora.org \
--cc=rshaffer@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.