From: Namhyung Kim <namhyung@gmail.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Ingo Molnar <mingo@elte.hu>,
Andrew Morton <akpm@linux-foundation.org>,
Alexander Viro <viro@zeniv.linux.org.uk>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] init/do_mounts.c: replace sys_mount() to do_mount()
Date: Tue, 17 Aug 2010 22:25:20 +0900 [thread overview]
Message-ID: <1282051520.1635.7.camel@leonhard> (raw)
In-Reply-To: <201008171515.26175.arnd@arndb.de>
2010-08-17 (화), 15:15 +0200, Arnd Bergmann:
> AFAICT there is no need for the copy at all here. The reason that sys_mount
> copies to a separate page is that it gets passed an arbitrary-length user
> input.
>
> Arnd
Right. But make sure to user options never exceed a page, do_mount() has
following code:
if (data_page)
((char *)data_page)[PAGE_SIZE - 1] = 0;
--
Regards,
Namhyung Kim
next prev parent reply other threads:[~2010-08-17 13:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-17 12:37 [PATCH] init/do_mounts.c: replace sys_mount() to do_mount() Namhyung Kim
2010-08-17 13:15 ` Arnd Bergmann
2010-08-17 13:25 ` Namhyung Kim [this message]
2010-08-17 13:41 ` Arnd Bergmann
2010-08-17 14:38 ` [PATCH v2] init: " Namhyung Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1282051520.1635.7.camel@leonhard \
--to=namhyung@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.