From: Joe Perches <joe@perches.com>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: Christoph Hellwig <hch@infradead.org>, "Ted Ts'o" <tytso@mit.edu>,
H Hartley Sweeten <hartleys@visionengravers.com>,
Linux Kernel <linux-kernel@vger.kernel.org>,
"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
"matthew@wil.cx" <matthew@wil.cx>
Subject: Re: [PATCH] fs.h: introduce functions to get/set file->private_data
Date: Tue, 17 Aug 2010 11:21:17 -0700 [thread overview]
Message-ID: <1282069277.14975.21.camel@Joe-Laptop> (raw)
In-Reply-To: <20100817175851.GA11463@merkur.ravnborg.org>
On Tue, 2010-08-17 at 19:58 +0200, Sam Ravnborg wrote:
> On Tue, Aug 17, 2010 at 10:26:13AM -0700, Joe Perches wrote:
> > On Tue, 2010-08-17 at 04:54 -0400, Christoph Hellwig wrote:
> > > On Mon, Aug 16, 2010 at 09:03:55PM -0400, Ted Ts'o wrote:
> > > > And spatch could also be used to rename private_data to f_private_data
> > > > if people really cared....
> > > Agreed, that's much better than adding useless accessors.
> > Against Linus' current, it's ~850KB.
> > Anyone really want it?
> a cleanup patch is far more convinient.
> It takes minimum effort to create and test, and if you can
> get ack from Ted and/or Christoph there is a good chance Linus
> would take it right before/after -rc1.
> You obviously need to convince him that the patch has
> seen decent build testing.
I don't have the passel of cross compilers,
so someone else would need to do that.
I compiled it 32 bit x86 allyesconfig only.
next prev parent reply other threads:[~2010-08-17 18:21 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-16 18:37 [PATCH] fs.h: introduce functions to get/set file->private_data H Hartley Sweeten
2010-08-16 23:17 ` Christoph Hellwig
2010-08-16 23:36 ` H Hartley Sweeten
2010-08-16 23:50 ` Joe Perches
2010-08-17 1:03 ` Ted Ts'o
2010-08-17 1:58 ` Joe Perches
2010-08-17 8:54 ` Christoph Hellwig
2010-08-17 8:54 ` Christoph Hellwig
2010-08-17 17:26 ` Joe Perches
2010-08-17 17:58 ` Sam Ravnborg
2010-08-17 18:21 ` Joe Perches [this message]
2010-08-18 1:32 ` Joe Perches
2010-08-18 16:48 ` H Hartley Sweeten
2010-08-18 16:48 ` H Hartley Sweeten
2010-08-18 17:15 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1282069277.14975.21.camel@Joe-Laptop \
--to=joe@perches.com \
--cc=hartleys@visionengravers.com \
--cc=hch@infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matthew@wil.cx \
--cc=sam@ravnborg.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.