All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Guy, Wey-Yi" <wey-yi.w.guy@intel.com>
To: "John W. Linville" <linville@tuxdriver.com>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
	"ipw3945-devel@lists.sourceforge.net"
	<ipw3945-devel@lists.sourceforge.net>,
	"Berg, Johannes" <johannes.berg@intel.com>
Subject: Re: [PATCH 2/2] iwlwifi: do not spuriously call ieee80211_scan_completed
Date: Wed, 18 Aug 2010 09:50:34 -0700	[thread overview]
Message-ID: <1282150234.4235.0.camel@wwguy-huron> (raw)
In-Reply-To: <20100818164405.GA2793@tuxdriver.com>

On Wed, 2010-08-18 at 09:44 -0700, John W. Linville wrote:
> On Wed, Aug 18, 2010 at 09:35:22AM -0700, Wey-Yi Guy wrote:
> > From: Johannes Berg <johannes.berg@intel.com>
> > 
> > When a scan is aborted because the corresponding
> > virtual interface is removed, we may still later
> > attempt to tell mac80211 that the scan completed.
> > This is obviously wrong, since we already told it
> > that it was aborted, so don't do that.
> > 
> > Signed-off-by: Johannes Berg <johannes.berg@intel.com>
> > Signed-off-by: Wey-Yi Guy <wey-yi.w.guy@intel.com>
> 
> Does this really qualify as a fix for 2.6.36?  Is it a regression?
> Does it generate an oops?  Or loss of connectivity?
> 
Johannes, could you help to answer.

Thanks
Wey



  reply	other threads:[~2010-08-18 16:46 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-18 16:35 [PATCH 0/2] iwlwifi fix for 2.6.35 Wey-Yi Guy
2010-08-18 16:35 ` [PATCH 1/2] iwlagn: do not check for AP mode for WEP keys Wey-Yi Guy
2010-08-18 16:40   ` Johannes Berg
2010-08-18 16:51     ` Guy, Wey-Yi
2010-08-18 16:35 ` [PATCH 2/2] iwlwifi: do not spuriously call ieee80211_scan_completed Wey-Yi Guy
2010-08-18 16:44   ` John W. Linville
2010-08-18 16:50     ` Guy, Wey-Yi [this message]
2010-08-18 16:53     ` Berg, Johannes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1282150234.4235.0.camel@wwguy-huron \
    --to=wey-yi.w.guy@intel.com \
    --cc=ipw3945-devel@lists.sourceforge.net \
    --cc=johannes.berg@intel.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.