All of lore.kernel.org
 help / color / mirror / Atom feed
From: Artem Bityutskiy <dedekind1@gmail.com>
To: don.mullis@gmail.com
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/6] improve list_sort test
Date: Sat, 21 Aug 2010 20:48:36 +0300	[thread overview]
Message-ID: <1282412916.2269.1.camel@brekeke> (raw)
In-Reply-To: <87lj7zgaw8.fsf@gmail.com>

On Sat, 2010-08-21 at 09:59 -0700, don.mullis@gmail.com wrote:
> Thanks, Artem.  I've prepared and tested locally a patch series that
> brings in most of the series you sent earlier, and adds a few more
> cleanups.  The one patch of yours that I did replace was the last one,
> that modifies semantics of the correctness test.  My reasoning is that
> the value of testing lies in exposing bugs, as economically as possible,
> and your test wasn't exposing my power-of-two bug.  So I created an
> alternative that's as simple as possible while picking at the corner
> cases, e.g. power-of-two.

That's fine, thanks.

> Last in my local patch series is the bug fix itself.  Setting
> CONFIG_TEST_LIST_SORT and testing with all but the last patch applied
> produces failure messages on the boot console.  Pushing the final "fix"
> patch makes them go away :-)

Sounds good.

> Okay if I incorporate your comment addition, above, and post the series
> for review?

Sure, I'll be happy if you take care of this, just keep me in CC when
you submit the patches, please.

Thanks,
Artem.


      reply	other threads:[~2010-08-21 17:48 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-07  8:10 [PATCH 0/6] improve list_sort test Artem Bityutskiy
2010-08-07  8:10 ` [PATCH 1/6] lib/Kconfig.debug: add list_sort debugging switch Artem Bityutskiy
2010-08-07  8:10 ` [PATCH 2/6] lib/list_sort: test: use more reasonable printk levels Artem Bityutskiy
2010-08-07  8:10 ` [PATCH 3/6] lib/list_sort: test: use generic random32 Artem Bityutskiy
2010-08-07  8:10 ` [PATCH 4/6] lib/list_sort: test: improve errors handling Artem Bityutskiy
2010-08-07  8:10 ` [PATCH 5/6] lib/list_sort: test: unify test messages Artem Bityutskiy
2010-08-07  8:10 ` [PATCH 6/6] lib/list_sort: test: check element addresses Artem Bityutskiy
2010-08-08 10:03 ` [PATCH 0/6] improve list_sort test Artem Bityutskiy
2010-08-08 19:31   ` Don Mullis
2010-08-08 20:07     ` Don Mullis
2010-08-09  5:59       ` Artem Bityutskiy
2010-08-21  9:56       ` Artem Bityutskiy
2010-08-21 10:03       ` Artem Bityutskiy
2010-08-21 10:06       ` [PATCH] lib/list_sort: do not pass bad pointers to cmp callback Artem Bityutskiy
2010-08-21  9:32     ` [PATCH 0/6] improve list_sort test Artem Bityutskiy
2010-08-21 10:22 ` Artem Bityutskiy
2010-08-21 16:59   ` don.mullis
2010-08-21 17:48     ` Artem Bityutskiy [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1282412916.2269.1.camel@brekeke \
    --to=dedekind1@gmail.com \
    --cc=don.mullis@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.