All of lore.kernel.org
 help / color / mirror / Atom feed
From: Liam Girdwood <lrg@slimlogic.co.uk>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: alsa-devel@alsa-project.org,
	"Mark Brown" <broonie@opensource.wolfsonmicro.com>,
	"Eric Bénard" <eric@eukrea.com>
Subject: Re: ASoC i.MX ssi: use SSI_STCCR in synchronous mode
Date: Mon, 23 Aug 2010 11:38:23 +0100	[thread overview]
Message-ID: <1282559903.3053.26.camel@odin> (raw)
In-Reply-To: <20100823065402.GR27749@pengutronix.de>

On Mon, 2010-08-23 at 08:54 +0200, Sascha Hauer wrote:
> Hi,
> 
> This time with cc list.
> 
> Please consider applying for -rc.
> 
> Sascha
> 
> 
> In synchronous mode the SSI_SRCCR values are ignored. Instead
> SSI_STCCR must be used for both receiving and transmitting.
> 
> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
> ---
>  sound/soc/imx/imx-ssi.c |    3 +++
>  1 files changed, 3 insertions(+), 0 deletions(-)
> 
> diff --git a/sound/soc/imx/imx-ssi.c b/sound/soc/imx/imx-ssi.c
> index a11daa1..c81da05 100644
> --- a/sound/soc/imx/imx-ssi.c
> +++ b/sound/soc/imx/imx-ssi.c
> @@ -254,6 +254,9 @@ static int imx_ssi_hw_params(struct snd_pcm_substream *substream,
>  		dma_data = &ssi->dma_params_rx;
>  	}
>  
> +	if (ssi->flags & IMX_SSI_SYN)
> +		reg = SSI_STCCR;
> +
>  	snd_soc_dai_set_dma_data(cpu_dai, substream, dma_data);
>  
>  	sccr = readl(ssi->base + reg) & ~SSI_STCCR_WL_MASK;
> -- 
> 1.7.1
> 
Acked-by: Liam Girdwood <lrg@slimlogic.co.uk>
-- 
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk

  reply	other threads:[~2010-08-23 10:38 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-23  6:54 ASoC i.MX ssi: use SSI_STCCR in synchronous mode Sascha Hauer
2010-08-23 10:38 ` Liam Girdwood [this message]
2010-08-23 12:34 ` Mark Brown
  -- strict thread matches above, loose matches on Subject: below --
2010-08-23  6:52 Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1282559903.3053.26.camel@odin \
    --to=lrg@slimlogic.co.uk \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=eric@eukrea.com \
    --cc=s.hauer@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.