From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peter Clifton Subject: Re: [PATCH] drm/i915: Drop the msleep parameter to wait_for() Date: Tue, 24 Aug 2010 00:42:35 +0100 Message-ID: <1282606955.29375.9.camel@pcjc2lap> References: <1282475148-15951-10-git-send-email-chris@chris-wilson.co.uk> <1282582569-24138-1-git-send-email-chris@chris-wilson.co.uk> <1282605397.29375.7.camel@pcjc2lap> <8u3s94$gajv98@orsmga002.jf.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from ppsw-30.csi.cam.ac.uk (ppsw-30.csi.cam.ac.uk [131.111.8.130]) by gabe.freedesktop.org (Postfix) with ESMTP id 2D1409E7D5 for ; Mon, 23 Aug 2010 16:42:40 -0700 (PDT) In-Reply-To: <8u3s94$gajv98@orsmga002.jf.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Chris Wilson , "intel-gfx@lists.freedesktop.org" List-Id: intel-gfx@lists.freedesktop.org On Tue, 2010-08-24 at 00:33 +0100, Chris Wilson wrote: > On Tue, 24 Aug 2010 00:16:37 +0100, Peter Clifton wrote: > > I noticed that the patch changes the semantics of some of the wait_for > > calls. Previously, many were called with a zero msleep parameter - > > meaning the call would not msleep. With this patch, the cases below will > > now msleep(1), rather than not msleep'ing at all. > > Intentionally. The choices I made when adding the wait_for() were fairly > arbitrary. I'd err on the side of sleeping the extra milliseconds rather > than spend 500 microseconds busy-spinning. (I've have a different opinion > if these ever become the rate-limiting step in modesetting... ;-) Fair enough.. it just looked like it might have been a mistake since you had both re-factored the interface, and altered the semantics of some of its callers within the same commit. -- Peter Clifton Electrical Engineering Division, Engineering Department, University of Cambridge, 9, JJ Thomson Avenue, Cambridge CB3 0FA Tel: +44 (0)7729 980173 - (No signal in the lab!) Tel: +44 (0)1223 748328 - (Shared lab phone, ask for me)