Re: [Adeos-main] [PATCH 1/2] ipipe: Pass NTP-corrected time information from Linux to higher domains

[Philippe Gerum <rpm@xenomai.org>]

On Wed, 2010-08-25 at 10:58 +0200, Jan Kiszka wrote:
> Philippe Gerum wrote:
> > On Wed, 2010-08-25 at 10:50 +0200, Jan Kiszka wrote:
> >> Philippe Gerum wrote:
> >>> On Fri, 2010-07-02 at 13:50 +0200, Wolfgang Mauerer wrote:
> >>>
> >>> <snip>
> >>>
> >>>> diff --git a/include/linux/ipipe_tickdev.h b/include/linux/ipipe_tickdev.h
> >>>> index 4a1cb1b..86f13e0 100644
> >>>> --- a/include/linux/ipipe_tickdev.h
> >>>> +++ b/include/linux/ipipe_tickdev.h
> >>>> @@ -25,6 +25,7 @@
> >>>>  #if defined(CONFIG_IPIPE) && defined(CONFIG_GENERIC_CLOCKEVENTS)
> >>> Since we should have CONFIG_HAVE_IPIPE_HOSTRT by now, let's use it.
> >> Don't get yet how this fits here.
> > 
> > arch-dep would define CONFIG_HAVE_IPIPE_HOSTRT [if IPIPE]
> > 
> 
> Still don't see the relation to the line you cited above.
> 

That is because you chose to have CONFIG_IPIPE_HOSTRT and
CONFIG_HAVE_IPIPE_HOSTRT. I would have only defined the latter, the way
you define the former. I'm looking for the hostrt support to be compiled
in if CONFIG_HAVE_IPIPE_HOSTRT is available from the arch-dep section,
so we don't need CONFIG_IPIPE_HOSTRT. Generic bits may depend on HAVE_*
as well.

> Jan
> 

-- 
Philippe.