From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============3091539814598759012==" MIME-Version: 1.0 From: Marcel Holtmann Subject: Re: [PATCH] mbm: add quirks for Dell D5530 Date: Wed, 25 Aug 2010 20:05:57 +0200 Message-ID: <1282759557.6841.53.camel@localhost.localdomain> In-Reply-To: <4C754900.6060808@gmail.com> List-Id: To: ofono@ofono.org --===============3091539814598759012== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Hi Denis, > > Dell D5530 is an OEM version of F3507g. It has an annoying habit of > > announcing itself to world with its own name. It also crashes upon > > processing received cbs messages. > > --- > > plugins/mbm.c | 55 +++++++++++++++++++++++++++++++++++++++++++++++++= ++++-- > > 1 files changed, 53 insertions(+), 2 deletions(-) > > = > > diff --git a/plugins/mbm.c b/plugins/mbm.c > > index c9b0ea4..1c2b9a8 100644 > > --- a/plugins/mbm.c > > +++ b/plugins/mbm.c > > @@ -53,9 +53,15 @@ static const char *cfun_prefix[] =3D { "+CFUN:", NUL= L }; > > static const char *cpin_prefix[] =3D { "+CPIN:", NULL }; > > static const char *none_prefix[] =3D { NULL }; > > = > > +enum mbm_variant { > > + MBM_GENERIC, > > + MBM_DELL_D5530, /* OEM of F3507g */ > > +}; > > + > > struct mbm_data { > > GAtChat *modem_port; > > GAtChat *data_port; > > + enum mbm_variant variant; > > guint poll_source; > > guint poll_count; > > gboolean have_sim; > > @@ -137,9 +143,50 @@ static gboolean init_simpin_check(gpointer user_da= ta) > > return FALSE; > > } > > = > > +static void d5530_notify(GAtResult *result, gpointer user_data) > > +{ > > + DBG("D5530"); > > +} > > + > = > Should we really bother with this one? Or you're trying to be like > Marcel and waste some processing time with unused unsolicited > notifications? :) I think we should until we have this all figured out. More debug output is always a good thing. And yes, essentially there is some processing wasted, but then again, this hardware is so damn stupid broken it deserves to be punished ;) Regards Marcel --===============3091539814598759012==--