All of lore.kernel.org
 help / color / mirror / Atom feed
From: Timur Tabi <timur@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/2] cmp_bmp: allow negative X, Y values for display command
Date: Wed, 25 Aug 2010 16:36:50 -0500	[thread overview]
Message-ID: <1282772210-27066-1-git-send-email-timur@freescale.com> (raw)

The 'bmp display' command accepts optional X and Y values for the position
of the image to be displayed.  Change the code which parses the command line
to accept negative values.

This feature is useful if you want to use a frame buffer for the console, and
you want a banner displayed on the top of the screen that never scrolls off.
This can be accomplished by declaring that the width and height of the video
screen is smaller than it really is, and then drawing an image in the
undeclared area.

For example, if you have 1280x1024 monitor, and you want to display a banner
on the top of the screen that's 100 pixels tall, then video_hw_init() should
say that display is really 1280x924, and then the banner should be drawn at
position (0, -100).

Signed-off-by: Timur Tabi <timur@freescale.com>
---
 common/cmd_bmp.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/common/cmd_bmp.c b/common/cmd_bmp.c
index d51cc55..06c1547 100644
--- a/common/cmd_bmp.c
+++ b/common/cmd_bmp.c
@@ -122,8 +122,8 @@ static int do_bmp_display(cmd_tbl_t * cmdtp, int flag, int argc, char * const ar
 		break;
 	case 4:
 		addr = simple_strtoul(argv[1], NULL, 16);
-	        x = simple_strtoul(argv[2], NULL, 10);
-	        y = simple_strtoul(argv[3], NULL, 10);
+	        x = simple_strtol(argv[2], NULL, 10);
+	        y = simple_strtol(argv[3], NULL, 10);
 	        break;
 	default:
 		return cmd_usage(cmdtp);
-- 
1.7.2.1

             reply	other threads:[~2010-08-25 21:36 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-25 21:36 Timur Tabi [this message]
2010-08-27 11:46 ` [U-Boot] [PATCH 2/2] cmp_bmp: allow negative X, Y values for display command Detlev Zundel
2010-08-27 12:00   ` Tabi Timur-B04825
2010-08-27 13:14     ` Detlev Zundel
2010-08-27 14:00       ` Tabi Timur-B04825
2010-08-27 14:10         ` Reinhard Meyer
2010-08-27 14:28           ` Tabi Timur-B04825
2010-08-27 20:51 ` Timur Tabi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1282772210-27066-1-git-send-email-timur@freescale.com \
    --to=timur@freescale.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.