From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <Ian.Campbell@eu.citrix.com>
Subject: Re: xen_hvm_callback_vector
Date: Sat, 28 Aug 2010 19:19:17 +0100
Message-ID: <1283019557.3469.47.camel@localhost.localdomain>
References: <4C7842C3.2000300@goop.org>
Mime-Version: 1.0
Content-Type: text/plain; charset="ISO-8859-1"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <4C7842C3.2000300@goop.org>
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Jeremy Fitzhardinge <jeremy@goop.org>
Cc: "Xen-devel@lists.xensource.com" <Xen-devel@lists.xensource.com>, Stefano Stabellini <Stefano.Stabellini@eu.citrix.com>
List-Id: xen-devel@lists.xenproject.org

On Fri, 2010-08-27 at 23:57 +0100, Jeremy Fitzhardinge wrote:
> Should entry_64.S's xen_hvm_callback_vector be calling
> xen_evtchn_do_upcall or xen_hvm_evtchn_do_upcall?
> If not the hvm version, when does that get used?

xen_evtchn_do_upcall is used for the callback vector interrupt injection
(and regular PV obviously).

xen_hvm_evtchn_do_upcall is used by the old-style PCI IRQ injection
route in platform-pci.c if the callback vector is not available.

So entry_64.S should be using xen_evtchn_do_upcall.

Also, I think smp_xen_hvm_callback_vector is simply a redundant
duplicate of xen_evtchn_do_upcall which could be removed.

Ian.