From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Stancek Date: Tue, 12 Jul 2016 12:10:58 -0400 (EDT) Subject: [LTP] [PATCH] safe_macros: match oldlib SAFE_CLOSE with docs In-Reply-To: <20160712135542.GD2651@rei.suse.cz> References: <20160712135542.GD2651@rei.suse.cz> Message-ID: <1283099046.4208400.1468339858052.JavaMail.zimbra@redhat.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: ltp@lists.linux.it ----- Original Message ----- > From: "Cyril Hrubis" > To: "Jan Stancek" > Cc: ltp@lists.linux.it > Sent: Tuesday, 12 July, 2016 3:55:43 PM > Subject: Re: [LTP] [PATCH] safe_macros: match oldlib SAFE_CLOSE with docs > > Hi! > > Docs say that SAFE_CLOSE() sets the passed file descriptor to -1 > > after it's successfully closed, but oldlib SAFE_CLOSE doesn't > > do that. > > Have you tried to run at least syscalls testsuite after this change? That was the plan, but I didn't get to that today. I was thinking syscalls as well, since most common failure seems to be errno tests, trying to trigger EBADF, etc. I'll reply once I have results. Regards, Jan > > I do not expect that this will break anything, but there it's a possibility. > > -- > Cyril Hrubis > chrubis@suse.cz >