From: Artem Bityutskiy <dedekind1@gmail.com>
To: Mike Frysinger <vapier@gentoo.org>
Cc: David Woodhouse <dwmw2@infradead.org>,
Andrew Morton <akpm@linux-foundation.org>,
linux-mtd@lists.infradead.org,
uclinux-dist-devel@blackfin.uclinux.org
Subject: Re: [PATCH] mtd: Blackfin NFC: fix build error after nand_scan_ident() change
Date: Mon, 30 Aug 2010 15:56:13 +0300 [thread overview]
Message-ID: <1283172973.12995.73.camel@brekeke> (raw)
In-Reply-To: <1282974300-11664-1-git-send-email-vapier@gentoo.org>
On Sat, 2010-08-28 at 01:45 -0400, Mike Frysinger wrote:
> Seems some patches got out sync when being merged. The Blackfin NFC
> driver was updated to use nand_scan_ident(), but it missed the change
> where nand_scan_ident() now takes 3 arguments. So update this driver
> to fix build failures.
>
> Signed-off-by: Mike Frysinger <vapier@gentoo.org>
> ---
> note: this needs to be merged before 2.6.36 final
>
> drivers/mtd/nand/bf5xx_nand.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/mtd/nand/bf5xx_nand.c b/drivers/mtd/nand/bf5xx_nand.c
> index a382e3d..162c5ea 100644
> --- a/drivers/mtd/nand/bf5xx_nand.c
> +++ b/drivers/mtd/nand/bf5xx_nand.c
> @@ -710,7 +710,7 @@ static int bf5xx_nand_scan(struct mtd_info *mtd)
> struct nand_chip *chip = mtd->priv;
> int ret;
>
> - ret = nand_scan_ident(mtd, 1);
> + ret = nand_scan_ident(mtd, 1, NULL);
> if (ret)
> return ret;
Pushed to l2-mtd-2.6.git / master so far, but please, bug dwmw2 about
2.6.36 inclusion, I'll do this as well, though.
--
Best Regards,
Artem Bityutskiy (Битюцкий Артём)
next prev parent reply other threads:[~2010-08-30 12:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-28 5:45 [PATCH] mtd: Blackfin NFC: fix build error after nand_scan_ident() change Mike Frysinger
2010-08-30 12:56 ` Artem Bityutskiy [this message]
2010-10-16 9:14 ` [Uclinux-dist-devel] " Mike Frysinger
2010-10-22 15:54 ` [stable] " Greg KH
2010-10-22 19:42 ` [Uclinux-dist-devel] [stable] " Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1283172973.12995.73.camel@brekeke \
--to=dedekind1@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=dwmw2@infradead.org \
--cc=linux-mtd@lists.infradead.org \
--cc=uclinux-dist-devel@blackfin.uclinux.org \
--cc=vapier@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.