On Tue, 2010-06-08 at 17:26 +0800, Johan Hedberg wrote: > Hi Bastien, > > On Tue, Jun 08, 2010, Bastien Nocera wrote: > > > I have nothing against pushing the patch upstream as long as its coding > > > style issues are fixed: > > > > > Mixed tabs and spaces. > > > > You do realise that all those are cut'n'paste from another function in > > the same source file? > > Nope, didn't realize that. So the whole file needs coding style cleanups > then. I've only fixed the style problems in the patch itself. I'm happy to do the rest of the file, if you have a "indent" magic incantation for it. > > > > + fprintf(stderr, "Invalid Bluetooth address '%s'\n", argv[2]); > > > > > > Too long line. > > > > Right, I'll fix that. Done. Updated patch attached.