From: Ben Hutchings <ben@decadent.org.uk>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH net-2.6] 3c59x: Remove incorrect locking; correct documented lock hierarchy
Date: Thu, 02 Sep 2010 01:42:58 +0100 [thread overview]
Message-ID: <1283388178.5323.300.camel@localhost> (raw)
In-Reply-To: <20100901.173736.190380817.davem@davemloft.net>
[-- Attachment #1: Type: text/plain, Size: 836 bytes --]
On Wed, 2010-09-01 at 17:37 -0700, David Miller wrote:
> From: Ben Hutchings <ben@decadent.org.uk>
> Date: Wed, 01 Sep 2010 23:08:27 +0100
>
> > I think this is safe after all because ethtool and MII ioctls are all
> > serialised by the RTNL.
>
> Well since you said that there was a regression that you're unable
> to reproduce, I was trying to find a probably cause for it :-)
>
> I think you should work to resolve that report, and resend this
> locking patch once that is sorted out.
That regression seems to due to my *earlier* changes to locking. This
new patch fixes a different regression I found while trying to reproduce
that, and it has not been applied in Debian yet. Sorry for the
ambiguous wording.
Ben.
--
Ben Hutchings
Once a job is fouled up, anything done to improve it makes it worse.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 828 bytes --]
next prev parent reply other threads:[~2010-09-02 0:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-31 0:15 [PATCH net-2.6] 3c59x: Remove incorrect locking; correct documented lock hierarchy Ben Hutchings
2010-09-01 21:38 ` David Miller
2010-09-01 21:47 ` Ben Hutchings
2010-09-01 22:08 ` Ben Hutchings
2010-09-02 0:37 ` David Miller
2010-09-02 0:42 ` Ben Hutchings [this message]
2010-09-02 1:02 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1283388178.5323.300.camel@localhost \
--to=ben@decadent.org.uk \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.