Re: [PATCH] Don't install systemd scripts with --without-systemdsystemunitdir

[Michael Forney <mforney@mforney.org>]

[-- Attachment #1: Type: text/plain, Size: 1508 bytes --]

Excerpts from Martin Pitt's message of Mon Aug 30 23:58:47 -0700 2010:
> Hello Michael,
> 
> Michael Forney [2010-08-26 19:10 -0700]:
> > Currently, the scripts get installed to /no/ if that option is
> > specified.
> 
> I can't reproduce this: I tried
> 
>   ./configure --prefix=/usr --without-systemdsystemunitdir
>   make
>   make install DESTDIR=/tmp/x/
> 
> and I don't get a /tmp/x/no, nor does grepping for SYSTEMD reveal any
> assignment to "no".
> 
> What's the particular configure command you are using?
> 
> Martin

Hi Martin,

I am not sure why you are having trouble reproducing it. I ran the same
commands and still saw the issue I described. I have attached a log for
reference.

Logically though, what is happening is when
--without-systemdsystemunitdir gets passed to configure,
with_systemdsystemunitdir gets assigned the value 'no'. Configure then
checks if this string is non-zero (which it is), and enables
WITH_SYSTEMD. This causes the scripts to get installed to the directory
$(systemdsystemunitdir) which is 'no'.

This seems to be a problem with several projects using this option,
including NetworkManager, which has been fixed
(https://bugzilla.gnome.org/show_bug.cgi?id=628439), and dbus, which has
been not yet commented on
(https://bugs.freedesktop.org/attachment.cgi?id=38319).

I just tested this with master and I still see the problem. Are you sure
your build directory is clean?

Thanks for taking the time to look at my patch!

-- 
Michael Forney <mforney@mforney.org>

[-- Attachment #2: udev.log --]
[-- Type: application/octet-stream, Size: 29356 bytes --]