From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [xen-4.0-testing test] 2061: regressions - FAIL Date: Fri, 3 Sep 2010 19:11:50 +0100 Message-ID: <1283537510.3469.243.camel@localhost.localdomain> References: <19585.11453.829459.233212@mariner.uk.xensource.com> <20100903171729.GA16367@kremvax.cs.ubc.ca> <19585.11893.756884.189394@mariner.uk.xensource.com> <20100903173803.GA17663@kremvax.cs.ubc.ca> <19585.13107.325426.697689@mariner.uk.xensource.com> <20100903175413.GB17663@kremvax.cs.ubc.ca> <19585.13976.404518.700860@mariner.uk.xensource.com> <20100903180428.GC17663@kremvax.cs.ubc.ca> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20100903180428.GC17663@kremvax.cs.ubc.ca> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Brendan Cully Cc: Jeremy Fitzhardinge , "xen-devel@lists.xensource.com" , Ian Jackson List-Id: xen-devel@lists.xenproject.org On Fri, 2010-09-03 at 19:04 +0100, Brendan Cully wrote: > On Friday, 03 September 2010 at 18:55, Ian Jackson wrote: > > Brendan Cully writes ("Re: [Xen-devel] [xen-4.0-testing test] 2061: regressions - FAIL"): > > > Until the kernel modules are in their proper place, I think a less > > > drastic fix for your test suites would be to edit > > > tools/remus/kmod/Makefile and change > > > > > > test -d $(KERNELDIR) > > > > > > to > > > > > > test -f $(KERNELDIR)/Module.symvers > > > > > > which will still silently fail to build the modules if tools/remus > > > builds too early, but should suppress failure warnings. Completely > > > untested. > > > > I don't think this is reliable, is it ? As that .symvers file can be > > created before the kernel build is complete. So we can still reenter > > the whole kernel build. > > What do you mean 'reenter the whole kernel build'? Are you under the > impression that the kmod tree is somehow actually building in the > kernel build directory? > > As I said in an earlier email, it doesn't do that. It is just using > the kernel header files, like any other third party module. Normally > you could find them under /lib/modules/foo/build, but obviously that > doesn't apply here. Out of tree module builds require a configured kernel tree, which it is not when the race is lost. You can't use the kernel headers to build modules without a .config for example since they contain various #ifdef CONFIG_FOO stuff which affects the kernel ABI. Maybe we should drop the remus stuff from tools/Makefile and add an explicit call to "make -C tools/remus" (or whatever the path is) at the appropriate place at the end of the rule which builds the kernel? Ian.