From: Liam Girdwood <lrg@slimlogic.co.uk>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: Axel Lin <axel.lin@gmail.com>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] regulator: wm8350-regulator - fix the logic of checking REGULATOR_MODE_STANDBY mode
Date: Mon, 06 Sep 2010 11:22:57 +0100 [thread overview]
Message-ID: <1283768577.3078.13.camel@odin> (raw)
In-Reply-To: <20100906092305.GA10367@rakim.wolfsonmicro.main>
On Mon, 2010-09-06 at 10:23 +0100, Mark Brown wrote:
> On Mon, Sep 06, 2010 at 02:06:07PM +0800, Axel Lin wrote:
> > In wm8350_dcdc_set_mode(), we set DCx_SLEEP bit of WM8350_DCDC_SLEEP_OPTIONS
> > register for REGULATOR_MODE_STANDBY mode.
> > ( DCx_SLEEP bits: 0: Normal DC-DC operation 1: Select LDO mode )
>
> > In wm8350_dcdc_get_mode(), current logic to determinate
> > REGULATOR_MODE_STANDBY mode is just reverse.
> > ( sleep is set should mean REGULATOR_MODE_STANDBY mode. )
> >
> > Signed-off-by: Axel Lin <axel.lin@gmail.com>
>
> Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
All applied (last 4 regulator patches from Axel).
Thanks
Liam
--
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk
prev parent reply other threads:[~2010-09-06 10:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-06 6:06 [PATCH] regulator: wm8350-regulator - fix the logic of checking REGULATOR_MODE_STANDBY mode Axel Lin
2010-09-06 9:23 ` Mark Brown
2010-09-06 10:22 ` Liam Girdwood [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1283768577.3078.13.camel@odin \
--to=lrg@slimlogic.co.uk \
--cc=axel.lin@gmail.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.