From: Liam Girdwood <lrg@slimlogic.co.uk>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: alsa-devel@alsa-project.org, Jiri Slaby <jirislaby@gmail.com>
Subject: Re: [PATCH] ASoC: tlv320aic3x: Fix null pointer dereference when pdata is not set
Date: Mon, 06 Sep 2010 11:39:01 +0100 [thread overview]
Message-ID: <1283769541.3078.17.camel@odin> (raw)
In-Reply-To: <20100906094514.GC10367@rakim.wolfsonmicro.main>
On Mon, 2010-09-06 at 10:45 +0100, Mark Brown wrote:
> On Sun, Sep 05, 2010 at 07:10:22PM +0300, Jarkko Nikula wrote:
> > Null pointer dereference will occur from *setup = pdata->setup if pdata
> > is not set. Fix this by moving assignments from pdata inside non-null case.
> >
> > Thanks to Jiri Slaby <jirislaby@gmail.com> for noticing.
> >
> > Signed-off-by: Jarkko Nikula <jhnikula@gmail.com>
> > Cc: Jiri Slaby <jirislaby@gmail.com>
>
> Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
Applied.
Thanks
Liam
--
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk
prev parent reply other threads:[~2010-09-06 10:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-05 16:10 [PATCH] ASoC: tlv320aic3x: Fix null pointer dereference when pdata is not set Jarkko Nikula
2010-09-06 9:45 ` Mark Brown
2010-09-06 10:39 ` Liam Girdwood [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1283769541.3078.17.camel@odin \
--to=lrg@slimlogic.co.uk \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=jirislaby@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.