From: Joe Perches <joe@perches.com>
To: Mike Frysinger <vapier.adi@gmail.com>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: [rfc patch] treewide: Convert "static const char <*> foo[] =" to "static const char <*> const foo[] ="
Date: Thu, 09 Sep 2010 12:33:28 -0700 [thread overview]
Message-ID: <1284060808.24986.231.camel@Joe-Laptop> (raw)
In-Reply-To: <AANLkTimzAOvP62VnhpSmKoazKkPc30-YTy09g2eYPGBg@mail.gmail.com>
On Thu, 2010-09-09 at 15:16 -0400, Mike Frysinger wrote:
> On Thu, Sep 9, 2010 at 14:48, Joe Perches wrote:
> > could be warned by checkpatch
> i dont think you even need to check the contents. just match the base:
> char foo[]
> const char *foo[]
> we want to catch these even if it isnt static, and catching the
> forward decl would be useful too.
I think that's not so good.
There are times when a default is used but then modified.
For instance:
drivers/staging/comedi/drivers/comedi_bond.c: char file[] = "/dev/comediXXXXXX";
> your perl hack isnt quite right.
The script I posted doesn't eat that whitespace.
The diff I sent you did. I wouldn't post that.
> how about making a coccinelle patch ?
Not necessary I think.
If Julia or anyone else wants to, no objection.
next prev parent reply other threads:[~2010-09-09 19:33 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-09 18:22 [rfc patch] treewide: Convert "static const char <*> foo[] =" to "static const char <*> const foo[] =" Joe Perches
2010-09-09 18:29 ` Mike Frysinger
2010-09-09 18:48 ` Joe Perches
2010-09-09 19:16 ` Mike Frysinger
2010-09-09 19:33 ` Joe Perches [this message]
2010-09-09 19:40 ` Mike Frysinger
2010-09-09 19:48 ` Joe Perches
2010-09-09 19:50 ` Mike Frysinger
2010-09-09 20:05 ` Joe Perches
[not found] ` <SNT104-W3438BE3FC4EAC0A537D57EBA900@phx.gbl>
2011-04-19 13:59 ` Joe Perches
2010-09-09 19:21 ` [PATCH] scripts/checkpatch.pl: Add warnings for static char that could be static const char Joe Perches
2010-09-09 19:24 ` Mike Frysinger
2010-09-10 9:06 ` Andy Whitcroft
2010-09-10 9:30 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1284060808.24986.231.camel@Joe-Laptop \
--to=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=vapier.adi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.