From: Liam Girdwood <lrg@slimlogic.co.uk>
To: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Cc: Linux-ALSA <alsa-devel@alsa-project.org>,
Mark Brown <broonie@opensource.wolfsonmicro.com>,
Guennadi <g.liakhovetski@gmx.de>
Subject: Re: [PATCH] ASoC: fsi codecs: modify menu attribute on Kconfig
Date: Fri, 10 Sep 2010 12:20:04 +0100 [thread overview]
Message-ID: <1284117604.3088.229.camel@odin> (raw)
In-Reply-To: <w3pvd6enzyv.wl%kuninori.morimoto.gx@renesas.com>
On Fri, 2010-09-10 at 10:34 +0900, Kuninori Morimoto wrote:
> Current SND_FSI_xxx menu attributes were bool,
> but it should be tristate.
> This patch solve below report from Guennadi
>
> "bool" means, if someone is linking the whole ASoC into the kernel, they
> will not be able to build this as a module. Not a big deal, but you're
> stealing some freedom from the user.
>
> Reported-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Acked-by: Liam Girdwood <lrg@slimlogic.co.uk>
--
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk
next prev parent reply other threads:[~2010-09-10 11:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-10 1:34 [PATCH] ASoC: fsi codecs: modify menu attribute on Kconfig Kuninori Morimoto
2010-09-10 11:20 ` Liam Girdwood [this message]
2010-09-10 11:39 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1284117604.3088.229.camel@odin \
--to=lrg@slimlogic.co.uk \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=g.liakhovetski@gmx.de \
--cc=kuninori.morimoto.gx@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.