All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alex Elder <aelder@sgi.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH] xfs: stop using xfs_qm_dqtobp in xfs_qm_dqflush
Date: Fri, 10 Sep 2010 14:49:22 -0500	[thread overview]
Message-ID: <1284148162.2468.12.camel@doink> (raw)
In-Reply-To: <20100906014445.GB1587@infradead.org>

On Sun, 2010-09-05 at 21:44 -0400, Christoph Hellwig wrote:
> In xfs_qm_dqflush we know that q_blkno must be initialized already from a
> previous xfs_qm_dqread.  So instead of calling xfs_qm_dqtobp we can
> simply read the quota buffer directly.  This also saves us from a duplicate
> xfs_qm_dqcheck call check and allows xfs_qm_dqtobp to be simplified now
> that it is always called for a newly initialized inode.  In addition to
> that properly unwind all locks in xfs_qm_dqflush when xfs_qm_dqcheck
> fails.

Looks good.

Reviewed-by: Alex Elder <aelder@sgi.com>

> This mirrors a similar cleanup in the inode lookup done earlier.
> 
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> 
. . .

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

      reply	other threads:[~2010-09-10 19:49 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-06  1:44 [PATCH] xfs: stop using xfs_qm_dqtobp in xfs_qm_dqflush Christoph Hellwig
2010-09-10 19:49 ` Alex Elder [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1284148162.2468.12.camel@doink \
    --to=aelder@sgi.com \
    --cc=hch@infradead.org \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.