From: Dan Rosenberg <drosenberg@vsecurity.com>
To: j.dumon@option.com
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
security@kernel.org, davem@davemloft.net, stable@kernel.org
Subject: [PATCH v2] drivers/net/usb/hso.c: prevent reading uninitialized memory
Date: Wed, 15 Sep 2010 17:43:28 -0400 [thread overview]
Message-ID: <1284587008.6275.95.camel@dan> (raw)
Fixed formatting (tabs and line breaks).
The TIOCGICOUNT device ioctl allows unprivileged users to read
uninitialized stack memory, because the "reserved" member of the
serial_icounter_struct struct declared on the stack in hso_get_count()
is not altered or zeroed before being copied back to the user. This
patch takes care of it.
Signed-off-by: Dan Rosenberg <dan.j.rosenberg@gmail.com>
--- linux-2.6.35.4.orig/drivers/net/usb/hso.c 2010-08-26 19:47:12.000000000 -0400
+++ linux-2.6.35.4/drivers/net/usb/hso.c 2010-09-14 21:26:18.477585183 -0400
@@ -1653,6 +1653,8 @@ static int hso_get_count(struct hso_seri
struct uart_icount cnow;
struct hso_tiocmget *tiocmget = serial->tiocmget;
+ memset(&icount, 0, sizeof(struct serial_icounter_struct));
+
if (!tiocmget)
return -ENOENT;
spin_lock_irq(&serial->serial_lock);
next reply other threads:[~2010-09-15 21:49 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-15 21:43 Dan Rosenberg [this message]
2010-09-16 15:57 ` [PATCH v2] drivers/net/usb/hso.c: prevent reading uninitialized memory Steven Rostedt
2010-09-16 17:07 ` Alan Cox
2010-09-16 16:52 ` Steven Rostedt
2010-09-16 17:47 ` Alan Cox
2010-09-16 17:36 ` Steven Rostedt
2010-09-17 4:55 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1284587008.6275.95.camel@dan \
--to=drosenberg@vsecurity.com \
--cc=davem@davemloft.net \
--cc=j.dumon@option.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=security@kernel.org \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.