From: Luciano Coelho <luciano.coelho@nokia.com>
To: ext Eliad Peller <eliad@wizery.com>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH 2/2] wl1271: bugfix: use bitwise-AND instead of logical-AND
Date: Sun, 19 Sep 2010 22:47:15 +0300 [thread overview]
Message-ID: <1284925635.10001.5.camel@powerslave> (raw)
In-Reply-To: <1284915309-999-2-git-send-email-eliad@wizery.com>
On Sun, 2010-09-19 at 18:55 +0200, ext Eliad Peller wrote:
> typo - while looking for specific bits we should do a bitwise-AND instead of logical-AND.
>
> Signed-off-by: Eliad Peller <eliad@wizery.com>
> ---
> drivers/net/wireless/wl12xx/wl1271_main.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/wireless/wl12xx/wl1271_main.c b/drivers/net/wireless/wl12xx/wl1271_main.c
> index e6e0852..d2b8486 100644
> --- a/drivers/net/wireless/wl12xx/wl1271_main.c
> +++ b/drivers/net/wireless/wl12xx/wl1271_main.c
> @@ -1635,7 +1635,7 @@ static void wl1271_op_bss_info_changed(struct ieee80211_hw *hw,
> if (ret < 0)
> goto out;
>
> - if ((changed && BSS_CHANGED_BEACON_INT) &&
> + if ((changed & BSS_CHANGED_BEACON_INT) &&
> (wl->bss_type == BSS_TYPE_IBSS)) {
> wl1271_debug(DEBUG_ADHOC, "ad-hoc beacon interval updated: %d",
> bss_conf->beacon_int);
> @@ -1644,7 +1644,7 @@ static void wl1271_op_bss_info_changed(struct ieee80211_hw *hw,
> do_join = true;
> }
>
> - if ((changed && BSS_CHANGED_BEACON) &&
> + if ((changed & BSS_CHANGED_BEACON) &&
> (wl->bss_type == BSS_TYPE_IBSS)) {
> struct sk_buff *beacon = ieee80211_beacon_get(hw, vif);
Acked-by: Luciano Coelho <luciano.coelho@nokia.com>
Nice catch! Thanks for your patch.
--
Cheers,
Luca.
next prev parent reply other threads:[~2010-09-19 19:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-19 16:55 [PATCH 1/2] wl1271: avoid redundant memcpy of rx_status Eliad Peller
2010-09-19 16:55 ` [PATCH 2/2] wl1271: bugfix: use bitwise-AND instead of logical-AND Eliad Peller
2010-09-19 19:47 ` Luciano Coelho [this message]
2010-09-19 19:46 ` [PATCH 1/2] wl1271: avoid redundant memcpy of rx_status Luciano Coelho
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1284925635.10001.5.camel@powerslave \
--to=luciano.coelho@nokia.com \
--cc=eliad@wizery.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.