From: Artem Bityutskiy <dedekind1@gmail.com>
To: Roman Tereshonkov <roman.tereshonkov@nokia.com>
Cc: dwmw2@infradead.org, linux-mtd@lists.infradead.org
Subject: Re: [PATCH 1/2] mtd: prepare partition add and del functions for ioctl requests
Date: Mon, 20 Sep 2010 15:00:42 +0300 [thread overview]
Message-ID: <1284984042.5258.21.camel@localhost> (raw)
In-Reply-To: <1284972658.2286.52.camel@localhost>
On Mon, 2010-09-20 at 11:50 +0300, Artem Bityutskiy wrote:
> On Fri, 2010-09-17 at 13:31 +0300, Roman Tereshonkov wrote:
> > + list_for_each_entry(p, &mtd_partitions, list)
> > + if (p->master == master) {
> > + (start < (p->offset + p->mtd.size)))
> > + goto err_inv;
>
> Pardon?
Sorry, it is some Evolution (e-mail client) bug. The code is different,
it displays it incorrectly. I do not really why. The code is actually
different:
+ if (p->master == master) {
+ if ((start >= p->offset) &&
+ (start < (p->offset + p->mtd.size)))
+ goto err_inv;
I really do not know why Evolution decided to kill the "if" line...
--
Best Regards,
Artem Bityutskiy (Артём Битюцкий)
next prev parent reply other threads:[~2010-09-20 12:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-17 10:31 [PATCH 0/2] mtd: add BLKPG API based repartition support Roman Tereshonkov
2010-09-17 10:31 ` [PATCH 1/2] mtd: prepare partition add and del functions for ioctl requests Roman Tereshonkov
2010-09-17 10:31 ` [PATCH 2/2] mtd: add BLKPG API based repartition support Roman Tereshonkov
2010-09-20 8:50 ` [PATCH 1/2] mtd: prepare partition add and del functions for ioctl requests Artem Bityutskiy
2010-09-20 12:00 ` Artem Bityutskiy [this message]
2010-09-20 12:42 ` [PATCH 0/2] mtd: add BLKPG API based repartition support Artem Bityutskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1284984042.5258.21.camel@localhost \
--to=dedekind1@gmail.com \
--cc=dwmw2@infradead.org \
--cc=linux-mtd@lists.infradead.org \
--cc=roman.tereshonkov@nokia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.