All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andy Owen <andy-alsa@ultra-premium.com>
To: Takashi Iwai <tiwai@suse.de>
Cc: alsa-devel@alsa-project.org
Subject: Re: [PATCH 2/2] ALSA: ca0106: Fix mixer and dac channel	assignments.
Date: Wed, 22 Sep 2010 00:24:56 +1000	[thread overview]
Message-ID: <1285079096.5919.0.camel@marvin> (raw)
In-Reply-To: <s5hhbhjdwn9.wl%tiwai@suse.de>

On Tue, 2010-09-21 at 16:00 +0200, Takashi Iwai wrote:
> I wonder whether this can regress on other boards.
> The front channel is the obvious channel so this must have been
> tested.  Maybe we should change the mapping only for your specific
> model by adding some flag.

The behaviour I was seeing was that if I just added the device id, then
the front channel would work fine, but I would get no sound from the
rears, and the mixer controls didn't quite match the labels. 

I was a bit suspect of this change:

> -     if (chip->details->spi_dac && channel_id != PCM_FRONT_CHANNEL) {
> +     if (chip->details->spi_dac) {

But I convinced myself that it was a hack to work around the registers
being wrong in other places, and the card in its default state had the
front dac already powered up. Looking at the code, I can see similar
logic in the snd_ca0106_pcm_close_playback() function, which has a
special case for the front channel, and I think should also be modified.

I'll put together some revised patches (with sign offs and the proposed
fix) hopefully tomorrow.

If anyone has a ca0106 card that they can test this with, it would be
much appreciated.

Andy

  reply	other threads:[~2010-09-21 14:25 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-21 13:51 [PATCH 1/2] ALSA: ca0106 - add Sound Blaster 5.1vx info andy-alsa
2010-09-21 13:51 ` [PATCH 2/2] ALSA: ca0106: Fix mixer and dac channel assignments andy-alsa
2010-09-21 14:00   ` Takashi Iwai
2010-09-21 14:24     ` Andy Owen [this message]
2010-09-21 15:27       ` Takashi Iwai
2010-09-22 14:12         ` Andy Owen
     [not found]         ` <1285164542.1797.54.camel@marvin>
2010-09-22 14:17           ` Takashi Iwai
2010-09-21 13:57 ` [PATCH 1/2] ALSA: ca0106 - add Sound Blaster 5.1vx info Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1285079096.5919.0.camel@marvin \
    --to=andy-alsa@ultra-premium.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.