All of lore.kernel.org
 help / color / mirror / Atom feed
From: Luciano Coelho <luciano.coelho@nokia.com>
To: ext Jan Engelhardt <jengelh@medozas.de>
Cc: Patrick McHardy <kaber@trash.net>,
	"netfilter-devel@vger.kernel.org"
	<netfilter-devel@vger.kernel.org>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"sameo@linux.intel.com" <sameo@linux.intel.com>,
	"Ylalehto Janne (Nokia-MS/Tampere)" <janne.ylalehto@nokia.com>
Subject: Re: [PATCH RESEND 2/3] netfilter: xt_condition: change the value from boolean to u32
Date: Tue, 21 Sep 2010 23:00:50 +0300	[thread overview]
Message-ID: <1285099250.10579.18.camel@powerslave> (raw)
In-Reply-To: <alpine.LNX.2.01.1009152246180.5146@obet.zrqbmnf.qr>

On Wed, 2010-09-15 at 22:46 +0200, ext Jan Engelhardt wrote:
> On Wednesday 2010-09-15 22:41, Patrick McHardy wrote:
> 
> >Am 17.08.2010 10:36, schrieb Luciano Coelho:
> >>  static struct xt_match condition_mt_reg __read_mostly = {
> >>  	.name       = "condition",
> >> -	.revision   = 1,
> >> +	.revision   = 2,
> >
> >Is this previous version actually compatible with anything that has
> >ever been released?
> 
> Yes, rev1 is used by Xtables-addons.

Indeed.  It was Jan who recommended this to be changed to 2 to avoid
conflict with Xtables-addons.


-- 
Cheers,
Luca.


  reply	other threads:[~2010-09-21 20:01 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-17  8:36 [PATCH RESEND 0/3] netfilter: xtables: inclusion of condition match and target Luciano Coelho
2010-08-17  8:36 ` [PATCH RESEND 1/3] netfilter: xtables: inclusion of xt_condition Luciano Coelho
2010-09-15 20:39   ` Patrick McHardy
2010-09-15 20:52     ` Jan Engelhardt
2010-09-15 20:59       ` Patrick McHardy
2010-09-15 21:09         ` Jan Engelhardt
2010-09-16  5:38           ` Patrick McHardy
2010-09-21 20:02             ` Luciano Coelho
2010-09-22  6:46               ` Patrick McHardy
2010-09-21 19:59     ` Luciano Coelho
2010-08-17  8:36 ` [PATCH RESEND 2/3] netfilter: xt_condition: change the value from boolean to u32 Luciano Coelho
2010-09-15 20:41   ` Patrick McHardy
2010-09-15 20:46     ` Jan Engelhardt
2010-09-21 20:00       ` Luciano Coelho [this message]
2010-08-17  8:36 ` [PATCH RESEND 3/3] netfilter: xt_condition: add condition target support Luciano Coelho

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1285099250.10579.18.camel@powerslave \
    --to=luciano.coelho@nokia.com \
    --cc=janne.ylalehto@nokia.com \
    --cc=jengelh@medozas.de \
    --cc=kaber@trash.net \
    --cc=netdev@vger.kernel.org \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=sameo@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.