All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Zijlstra <peterz@infradead.org>
To: balbir@linux.vnet.ibm.com
Cc: eranian@google.com, linux-kernel@vger.kernel.org, mingo@elte.hu,
	paulus@samba.org, davem@davemloft.net, fweisbec@gmail.com,
	perfmon2-devel@lists.sf.net, eranian@gmail.com,
	robert.richter@amd.com, acme@redhat.com,
	Paul Menage <menage@google.com>, Li Zefan <lizf@cn.fujitsu.com>
Subject: Re: [RFC PATCH 0/2] perf_events: add support for per-cpu per-cgroup monitoring (v3)
Date: Wed, 22 Sep 2010 09:27:59 +0200	[thread overview]
Message-ID: <1285140479.2275.893.camel@laptop> (raw)
In-Reply-To: <20100922042354.GG6676@balbir.in.ibm.com>

On Wed, 2010-09-22 at 09:53 +0530, Balbir Singh wrote:
> Yes, a task can belong to multiple subsystems, hence multiple cgroups.
> Ideally we'd want to use pid + subsystem

Apparently we create a perf subsystem, and we only care about that. So
pid will uniquely identify a cgroup, since for each subsystem a task can
only belong to one cgroup.

> > One thing we could do is pass this cgroup identifier in the pid field
> > and use PERF_FLAG_CGROUP or something. Currently the syscall signature
> > uses pid_t, but I think we can safely change that to int.
> 
> Or union it and overload the field to contain either pid_t or fd of the cgroup

Its not a field, its an argument.

  reply	other threads:[~2010-09-22  7:28 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-09 13:05 [RFC PATCH 0/2] perf_events: add support for per-cpu per-cgroup monitoring (v3) Stephane Eranian
2010-09-21  9:38 ` Peter Zijlstra
2010-09-21  9:43   ` Peter Zijlstra
2010-09-21 11:48     ` Stephane Eranian
2010-09-21 12:42       ` Peter Zijlstra
2010-09-21 13:38         ` Stephane Eranian
2010-09-21 14:03           ` Peter Zijlstra
2010-09-21 16:17             ` Stephane Eranian
2010-09-21 16:27               ` Peter Zijlstra
2010-09-21 16:33                 ` Stephane Eranian
2010-09-22  4:34                 ` Balbir Singh
2010-09-22  7:25                   ` Peter Zijlstra
2010-09-22  4:23   ` Balbir Singh
2010-09-22  7:27     ` Peter Zijlstra [this message]
2010-09-22  9:18       ` Balbir Singh
2010-09-22 10:26         ` Stephane Eranian
2010-09-25  9:51           ` Peter Zijlstra
2010-09-28  9:23             ` Stephane Eranian

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1285140479.2275.893.camel@laptop \
    --to=peterz@infradead.org \
    --cc=acme@redhat.com \
    --cc=balbir@linux.vnet.ibm.com \
    --cc=davem@davemloft.net \
    --cc=eranian@gmail.com \
    --cc=eranian@google.com \
    --cc=fweisbec@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lizf@cn.fujitsu.com \
    --cc=menage@google.com \
    --cc=mingo@elte.hu \
    --cc=paulus@samba.org \
    --cc=perfmon2-devel@lists.sf.net \
    --cc=robert.richter@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.