From: Luciano Coelho <luciano.coelho@nokia.com>
To: ext Ido Yariv <ido@wizery.com>, John Linville <linville@tuxdriver.com>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"Katila Tuomas.2 (EXT-Ixonos/Tampere)"
<ext-tuomas.2.katila@nokia.com>
Subject: Re: [PATCH] wl1271: Fix overflow in wl1271_boot_upload_nvs
Date: Thu, 23 Sep 2010 10:46:33 +0300 [thread overview]
Message-ID: <1285227993.3231.19.camel@chilepepper> (raw)
In-Reply-To: <1285151082.22517.8.camel@chilepepper>
On Wed, 2010-09-22 at 12:24 +0200, Luciano Coelho wrote:
> On Wed, 2010-09-22 at 09:53 +0200, ext Ido Yariv wrote:
> > Due to miscalculation of nvs_len, excessive data was sent to the
> > firmware.
> > Fix this by first setting nvs_ptr to point to the first NVS table,
> > and computing the total size of all NVS tables accordingly.
> >
> > Signed-off-by: Ido Yariv <ido@wizery.com>
> > ---
>
> This looks reasonable, thanks!
>
> But I still want to have it briefly tested before I accept it. Our
> tester will try it out today or tomorrow and, if everything is okay,
> I'll ack it.
>
Okay, Tuomas has run some basic tests with this patch and didn't
observer any degradation in RF (which would signal possible problems
with the NVS uploading).
Thanks, Ido!
Tested-By: Tuomas Katila <ext-tuomas.2.katila@nokia.com>
Acked-by: Luciano Coelho <luciano.coelho@nokia.com>
John, please apply this patch, since my tree is not ready yet.
--
Cheers,
Luca.
prev parent reply other threads:[~2010-09-23 7:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-22 7:53 [PATCH] wl1271: Fix overflow in wl1271_boot_upload_nvs Ido Yariv
2010-09-22 10:24 ` Luciano Coelho
2010-09-23 7:46 ` Luciano Coelho [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1285227993.3231.19.camel@chilepepper \
--to=luciano.coelho@nokia.com \
--cc=ext-tuomas.2.katila@nokia.com \
--cc=ido@wizery.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.