From: Artem Bityutskiy <dedekind1@gmail.com>
To: Rohit Hassan Sathyanarayan <rohit.hs@samsung.com>
Cc: v.dalal@samsung.com, gupta.raghav@samsung.com,
linux-mtd@lists.infradead.org
Subject: Re: [PATCH RESEND][MTD]MLC device check in OneNAND driver
Date: Fri, 24 Sep 2010 14:52:04 +0300 [thread overview]
Message-ID: <1285329124.29268.175.camel@localhost> (raw)
In-Reply-To: <001701cb5bdd$3fd69a80$bf83cf80$%hs@samsung.com>
On Fri, 2010-09-24 at 17:10 +0530, Rohit Hassan Sathyanarayan wrote:
> Signed-off-by: Rohit HS <rohit.hs@samsung.com>
> Signed-off-by: Raghav Gupta <gupta.raghav@samsung.com>
Almost perfect. However:
1. All mtd patches should have "mtd:" prefix.
2. Add some description about what you do and why into the commit
message.
3. I think combining is not good, better do it old way - first patch
introduces the flag, second uses it in OneNAND
Sorry for being picky, but I really want to show you how to send patches
properly once and later get good series from you.
--
Best Regards,
Artem Bityutskiy (Артём Битюцкий)
next prev parent reply other threads:[~2010-09-24 11:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-24 11:40 [PATCH RESEND][MTD]MLC device check in OneNAND driver Rohit Hassan Sathyanarayan
2010-09-24 11:52 ` Artem Bityutskiy [this message]
2010-10-07 4:32 ` Rohit Hassan Sathyanarayan
2010-10-07 19:18 ` Artem Bityutskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1285329124.29268.175.camel@localhost \
--to=dedekind1@gmail.com \
--cc=gupta.raghav@samsung.com \
--cc=linux-mtd@lists.infradead.org \
--cc=rohit.hs@samsung.com \
--cc=v.dalal@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.