From: Thomas Monjalon <thomas@monjalon.net>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: dev@dpdk.org, Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [RFC 1/5] bus/pci: fix allocation of pci device path
Date: Sun, 18 Nov 2018 16:03:26 +0100 [thread overview]
Message-ID: <128547554.QZfPCpo1WU@xps> (raw)
In-Reply-To: <20181106214901.1392-2-stephen@networkplumber.org>
06/11/2018 22:48, Stephen Hemminger:
> The pci_resource_by_index called strlen() on uninitialized
> memory which would lead to the wrong size of memory allocated
> for the path portion of the resource map. This would either cause
> excessively large allocation, or worse memory corruption.
>
> Coverity Issue: 300868
> Fixes: ea9d56226e72 ("pci: introduce function to map uio resource by index")
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
This patch is RFC but Ferruh (UIO maintainer) was not Cc'ed.
I feel this bug is critical. Please advise.
next prev parent reply other threads:[~2018-11-18 15:03 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-06 21:48 [RFC 0/5] more Coverity related bug fixes Stephen Hemminger
2018-11-06 21:48 ` [RFC 1/5] bus/pci: fix allocation of pci device path Stephen Hemminger
2018-11-18 15:03 ` Thomas Monjalon [this message]
2018-11-22 23:52 ` Ferruh Yigit
2018-11-23 0:29 ` [PATCH] bus/pci: fix allocation of PCI " Ferruh Yigit
2018-11-23 10:45 ` Thomas Monjalon
2018-11-23 10:55 ` Andrew Rybchenko
2018-11-23 11:01 ` Maxime Coquelin
2018-11-25 10:53 ` Thomas Monjalon
2018-11-06 21:48 ` [RFC 2/5] bus/pci: fix TOCTOU issue Stephen Hemminger
2018-11-18 15:04 ` Thomas Monjalon
2018-11-06 21:48 ` [RFC 3/5] bpf: fix validation of eal_divmod Stephen Hemminger
2018-11-07 12:54 ` Ananyev, Konstantin
2018-11-07 19:51 ` Stephen Hemminger
2018-11-07 20:07 ` Ananyev, Konstantin
2018-11-07 23:04 ` Ananyev, Konstantin
2018-11-06 21:49 ` [RFC 4/5] eal/memory: avoid double munmap in error path Stephen Hemminger
2018-11-06 23:10 ` Thomas Monjalon
2018-11-06 21:49 ` [RFC 5/5] pipeline: remove dead code Stephen Hemminger
2018-11-18 15:07 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=128547554.QZfPCpo1WU@xps \
--to=thomas@monjalon.net \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.