From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757693Ab0IZSM2 (ORCPT ); Sun, 26 Sep 2010 14:12:28 -0400 Received: from proofpoint-cluster.metrocast.net ([65.175.128.136]:11866 "EHLO proofpoint-cluster.metrocast.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757027Ab0IZSM1 (ORCPT ); Sun, 26 Sep 2010 14:12:27 -0400 Subject: Re: [PATCH] drm/sysfs: Provide per connector control of DRM KMS polling From: Andy Walls To: Alex Deucher Cc: Jon Smirl , =?UTF-8?Q?Rafa=C5=82_Mi=C5=82ecki?= , Dave Airlie , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org In-Reply-To: References: <1284987540.2242.29.camel@morgan.silverblock.net> <1285023750.30856.99.camel@morgan.silverblock.net> <1285090202.19131.77.camel@morgan.silverblock.net> <1285189645.14364.55.camel@morgan.silverblock.net> Content-Type: text/plain; charset="UTF-8" Date: Sun, 26 Sep 2010 14:12:24 -0400 Message-ID: <1285524744.2277.41.camel@morgan.silverblock.net> Mime-Version: 1.0 X-Mailer: Evolution 2.28.3 (2.28.3-1.fc12) Content-Transfer-Encoding: 8bit X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:5.0.10011,1.0.148,0.0.0000 definitions=2010-09-26_01:2010-09-26,2010-09-25,1970-01-01 signatures=0 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 ipscore=0 phishscore=0 bulkscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx engine=5.0.0-1005130000 definitions=main-1009260113 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2010-09-24 at 15:12 -0400, Alex Deucher wrote: > On Wed, Sep 22, 2010 at 5:07 PM, Andy Walls wrote: > > On Wed, 2010-09-22 at 09:33 -0400, Jon Smirl wrote: > >> On Wed, Sep 22, 2010 at 1:30 AM, Alex Deucher wrote: > >> > On Tue, Sep 21, 2010 at 1:30 PM, Andy Walls wrote: > >> >> On Tue, 2010-09-21 at 00:26 -0400, Alex Deucher wrote: > >> >>> 2010/9/20 Andy Walls : > >> >>> > On Mon, 2010-09-20 at 20:29 +0200, Rafał Miłecki wrote: > >> >>> >> 2010/9/20 Andy Walls : > > > >> >> The real problem to me is that the radeon and drm modules have a single, > >> >> standard way of dealing with EDID errors. However, EDID errors can > >> >> happen due to a number of different causes, some of which are external > >> >> (i.e. in the LCD or CRT monitor). Given that, there really is no "right > >> >> thing" the drivers can do without input from the user on what the policy > >> >> should be when a bad EDID is detected. > >> > The attached patch should fix up your board. Let me know if it works for you. That patch suppresses the setup of the HDMI and DVI connectors that don't exist, so the log spam from polling for EDID's is gone for me. [PATCH] drm/radeon/kms: add quirk for MSI K9A2GM motherboard Board has no digital connectors Reported-by: Andy Walls Tested-by: Andy Walls Signed-off-by: Alex Deucher Cc: stable@kernel.org Yes it works for me, but it's what I'd call a "point solution". There are still these which appear to be the exact same symptoms (perpetual EDID log spam) just for different hardware setups: https://bugs.freedesktop.org/show_bug.cgi?id=27708 https://partner-bugzilla.redhat.com/show_bug.cgi?id=610362 Here was a broader solution for a particular class of machines (Laptops with i915 chips with an LVDS with a broken EDID) exhibiting those same symptoms: https://patchwork.kernel.org/patch/83556/ Picking these bugs off one or two at a time, as users report the same symptoms over an over again, is really a waste of users' time. Users wait while their report is queued, a custom kernel patch developed, and a kernel patch makes it through their distro to them. On a different subject, with your patch applied, I'm now seeing a new error message in my log that I have not seen before: failed to evaluate ATIF got AE_BAD_PARAMETER Here's the dmesg from drm: [drm] Initialized drm 1.1.0 20060810 [drm] radeon defaulting to kernel modesetting. [drm] radeon kernel modesetting enabled. radeon 0000:01:05.0: PCI INT A -> GSI 18 (level, low) -> IRQ 18 [drm] initializing kernel modesetting (RS740 0x1002:0x796E). [drm] register mmio base: 0xFE7F0000 [drm] register mmio size: 65536 ATOM BIOS: ATI radeon 0000:01:05.0: VRAM: 128M 0x78000000 - 0x7FFFFFFF (128M used) radeon 0000:01:05.0: GTT: 512M 0x80000000 - 0x9FFFFFFF [drm] radeon: irq initialized. [drm] Detected VRAM RAM=128M, BAR=128M [drm] RAM width 128bits DDR [TTM] Zone kernel: Available graphics memory: 963022 kiB. [TTM] Initializing pool allocator. [drm] radeon: 128M of VRAM memory ready [drm] radeon: 512M of GTT memory ready. [drm] GART: num cpu pages 131072, num gpu pages 131072 [drm] radeon: 1 quad pipes, 1 z pipes initialized. [drm] Loading RS690/RS740 Microcode [drm] radeon: ring at 0x0000000080000000 [drm] ring test succeeded in 1 usecs [drm] radeon: ib pool ready. [drm] ib test succeeded in 0 usecs [drm] Enabling audio support failed to evaluate ATIF got AE_BAD_PARAMETER [drm] Default TV standard: NTSC [drm] Radeon Display Connectors [drm] Connector 0: [drm] VGA [drm] DDC: 0x7e50 0x7e40 0x7e54 0x7e44 0x7e58 0x7e48 0x7e5c 0x7e4c [drm] Encoders: [drm] CRT1: INTERNAL_KLDSCP_DAC1 [drm] fb mappable at 0xD8040000 [drm] vram apper at 0xD8000000 [drm] size 4325376 [drm] fb depth is 24 [drm] pitch is 5632 fbcon: radeondrmfb (fb0) is primary device Console: switching to colour frame buffer device 170x48 fb0: radeondrmfb frame buffer device drm: registered panic notifier Slow work thread pool: Starting up Slow work thread pool: Ready [drm] Initialized radeon 2.6.0 20080528 for 0000:01:05.0 on minor 0 By inspection of the code, it looks like the handle being passed into radeon_atif_call() by radeon_acpi_init() may be bad. I'm not sure why that would be though. I won't have time until Thursday to run it down any further. Regards, Andy > Thanks, > > Alex From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andy Walls Subject: Re: [PATCH] drm/sysfs: Provide per connector control of DRM KMS polling Date: Sun, 26 Sep 2010 14:12:24 -0400 Message-ID: <1285524744.2277.41.camel@morgan.silverblock.net> References: <1284987540.2242.29.camel@morgan.silverblock.net> <1285023750.30856.99.camel@morgan.silverblock.net> <1285090202.19131.77.camel@morgan.silverblock.net> <1285189645.14364.55.camel@morgan.silverblock.net> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from proofpoint-cluster.metrocast.net (proofpoint-cluster.metrocast.net [65.175.128.136]) by gabe.freedesktop.org (Postfix) with ESMTP id 9AE169E9AC for ; Sun, 26 Sep 2010 11:12:14 -0700 (PDT) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: Alex Deucher Cc: Greg Kroah-Hartman , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Jon Smirl , Dave Airlie List-Id: dri-devel@lists.freedesktop.org T24gRnJpLCAyMDEwLTA5LTI0IGF0IDE1OjEyIC0wNDAwLCBBbGV4IERldWNoZXIgd3JvdGU6Cj4g T24gV2VkLCBTZXAgMjIsIDIwMTAgYXQgNTowNyBQTSwgQW5keSBXYWxscyA8YXdhbGxzQG1kLm1l dHJvY2FzdC5uZXQ+IHdyb3RlOgo+ID4gT24gV2VkLCAyMDEwLTA5LTIyIGF0IDA5OjMzIC0wNDAw LCBKb24gU21pcmwgd3JvdGU6Cj4gPj4gT24gV2VkLCBTZXAgMjIsIDIwMTAgYXQgMTozMCBBTSwg QWxleCBEZXVjaGVyIDxhbGV4ZGV1Y2hlckBnbWFpbC5jb20+IHdyb3RlOgo+ID4+ID4gT24gVHVl LCBTZXAgMjEsIDIwMTAgYXQgMTozMCBQTSwgQW5keSBXYWxscyA8YXdhbGxzQG1kLm1ldHJvY2Fz dC5uZXQ+IHdyb3RlOgo+ID4+ID4+IE9uIFR1ZSwgMjAxMC0wOS0yMSBhdCAwMDoyNiAtMDQwMCwg QWxleCBEZXVjaGVyIHdyb3RlOgo+ID4+ID4+PiAyMDEwLzkvMjAgQW5keSBXYWxscyA8YXdhbGxz QG1kLm1ldHJvY2FzdC5uZXQ+Ogo+ID4+ID4+PiA+IE9uIE1vbiwgMjAxMC0wOS0yMCBhdCAyMDoy OSArMDIwMCwgUmFmYcWCIE1pxYJlY2tpIHdyb3RlOgo+ID4+ID4+PiA+PiAyMDEwLzkvMjAgQW5k eSBXYWxscyA8YXdhbGxzQG1kLm1ldHJvY2FzdC5uZXQ+Ogo+ID4KPiA+PiA+PiBUaGUgcmVhbCBw cm9ibGVtIHRvIG1lIGlzIHRoYXQgdGhlIHJhZGVvbiBhbmQgZHJtIG1vZHVsZXMgaGF2ZSBhIHNp bmdsZSwKPiA+PiA+PiBzdGFuZGFyZCB3YXkgb2YgZGVhbGluZyB3aXRoIEVESUQgZXJyb3JzLiAg SG93ZXZlciwgRURJRCBlcnJvcnMgY2FuCj4gPj4gPj4gaGFwcGVuIGR1ZSB0byBhIG51bWJlciBv ZiBkaWZmZXJlbnQgY2F1c2VzLCBzb21lIG9mIHdoaWNoIGFyZSBleHRlcm5hbAo+ID4+ID4+IChp LmUuIGluIHRoZSBMQ0Qgb3IgQ1JUIG1vbml0b3IpLiAgR2l2ZW4gdGhhdCwgdGhlcmUgcmVhbGx5 IGlzIG5vICJyaWdodAo+ID4+ID4+IHRoaW5nIiB0aGUgZHJpdmVycyBjYW4gZG8gd2l0aG91dCBp bnB1dCBmcm9tIHRoZSB1c2VyIG9uIHdoYXQgdGhlIHBvbGljeQo+ID4+ID4+IHNob3VsZCBiZSB3 aGVuIGEgYmFkIEVESUQgaXMgZGV0ZWN0ZWQuCj4gPj4KCgo+IFRoZSBhdHRhY2hlZCBwYXRjaCBz aG91bGQgZml4IHVwIHlvdXIgYm9hcmQuICBMZXQgbWUga25vdyBpZiBpdCB3b3JrcyBmb3IgeW91 LgoKVGhhdCBwYXRjaCBzdXBwcmVzc2VzIHRoZSBzZXR1cCBvZiB0aGUgSERNSSBhbmQgRFZJIGNv bm5lY3RvcnMgdGhhdApkb24ndCBleGlzdCwgc28gdGhlIGxvZyBzcGFtIGZyb20gcG9sbGluZyBm b3IgRURJRCdzIGlzIGdvbmUgZm9yIG1lLgoKICAgICAgICBbUEFUQ0hdIGRybS9yYWRlb24va21z OiBhZGQgcXVpcmsgZm9yIE1TSSBLOUEyR00gbW90aGVyYm9hcmQKICAgICAgICAKICAgICAgICBC b2FyZCBoYXMgbm8gZGlnaXRhbCBjb25uZWN0b3JzCiAgICAgICAgCiAgICAgICAgUmVwb3J0ZWQt Ynk6IEFuZHkgV2FsbHMgPGF3YWxsc0BtZC5tZXRyb2Nhc3QubmV0PgogICAgICAgIFRlc3RlZC1i eTogQW5keSBXYWxscyA8YXdhbGxzQG1kLm1ldHJvY2FzdC5uZXQ+CiAgICAgICAgU2lnbmVkLW9m Zi1ieTogQWxleCBEZXVjaGVyIDxhbGV4ZGV1Y2hlckBnbWFpbC5jb20+CiAgICAgICAgQ2M6IHN0 YWJsZUBrZXJuZWwub3JnCgoKWWVzIGl0IHdvcmtzIGZvciBtZSwgYnV0IGl0J3Mgd2hhdCBJJ2Qg Y2FsbCBhICJwb2ludCBzb2x1dGlvbiIuICBUaGVyZQphcmUgc3RpbGwgdGhlc2Ugd2hpY2ggYXBw ZWFyIHRvIGJlIHRoZSBleGFjdCBzYW1lIHN5bXB0b21zIChwZXJwZXR1YWwKRURJRCBsb2cgc3Bh bSkganVzdCBmb3IgZGlmZmVyZW50IGhhcmR3YXJlIHNldHVwczoKCiAgICAgICAgaHR0cHM6Ly9i dWdzLmZyZWVkZXNrdG9wLm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Mjc3MDgKICAgICAgICBodHRwczov L3BhcnRuZXItYnVnemlsbGEucmVkaGF0LmNvbS9zaG93X2J1Zy5jZ2k/aWQ9NjEwMzYyCiAgICAg ICAgCgpIZXJlIHdhcyBhIGJyb2FkZXIgc29sdXRpb24gZm9yIGEgcGFydGljdWxhciBjbGFzcyBv ZiBtYWNoaW5lcyAoTGFwdG9wcwp3aXRoIGk5MTUgY2hpcHMgd2l0aCBhbiBMVkRTIHdpdGggYSBi cm9rZW4gRURJRCkgZXhoaWJpdGluZyB0aG9zZSBzYW1lCnN5bXB0b21zOgoKICAgICAgICBodHRw czovL3BhdGNod29yay5rZXJuZWwub3JnL3BhdGNoLzgzNTU2LwoKUGlja2luZyB0aGVzZSBidWdz IG9mZiBvbmUgb3IgdHdvIGF0IGEgdGltZSwgYXMgdXNlcnMgcmVwb3J0IHRoZSBzYW1lCnN5bXB0 b21zIG92ZXIgYW4gb3ZlciBhZ2FpbiwgaXMgcmVhbGx5IGEgd2FzdGUgb2YgdXNlcnMnIHRpbWUu ICBVc2Vycwp3YWl0IHdoaWxlIHRoZWlyIHJlcG9ydCBpcyBxdWV1ZWQsIGEgY3VzdG9tIGtlcm5l bCBwYXRjaCBkZXZlbG9wZWQsIGFuZAphIGtlcm5lbCBwYXRjaCBtYWtlcyBpdCB0aHJvdWdoIHRo ZWlyIGRpc3RybyB0byB0aGVtLgoKCk9uIGEgZGlmZmVyZW50IHN1YmplY3QsIHdpdGggeW91ciBw YXRjaCBhcHBsaWVkLCBJJ20gbm93IHNlZWluZyBhIG5ldwplcnJvciBtZXNzYWdlIGluIG15IGxv ZyB0aGF0IEkgaGF2ZSBub3Qgc2VlbiBiZWZvcmU6CgoJZmFpbGVkIHRvIGV2YWx1YXRlIEFUSUYg Z290IEFFX0JBRF9QQVJBTUVURVIKCkhlcmUncyB0aGUgZG1lc2cgZnJvbSBkcm06CgogICAgICAg IFtkcm1dIEluaXRpYWxpemVkIGRybSAxLjEuMCAyMDA2MDgxMAogICAgICAgIFtkcm1dIHJhZGVv biBkZWZhdWx0aW5nIHRvIGtlcm5lbCBtb2Rlc2V0dGluZy4KICAgICAgICBbZHJtXSByYWRlb24g a2VybmVsIG1vZGVzZXR0aW5nIGVuYWJsZWQuCiAgICAgICAgcmFkZW9uIDAwMDA6MDE6MDUuMDog UENJIElOVCBBIC0+IEdTSSAxOCAobGV2ZWwsIGxvdykgLT4gSVJRIDE4CiAgICAgICAgW2RybV0g aW5pdGlhbGl6aW5nIGtlcm5lbCBtb2Rlc2V0dGluZyAoUlM3NDAgMHgxMDAyOjB4Nzk2RSkuCiAg ICAgICAgW2RybV0gcmVnaXN0ZXIgbW1pbyBiYXNlOiAweEZFN0YwMDAwCiAgICAgICAgW2RybV0g cmVnaXN0ZXIgbW1pbyBzaXplOiA2NTUzNgogICAgICAgIEFUT00gQklPUzogQVRJCiAgICAgICAg cmFkZW9uIDAwMDA6MDE6MDUuMDogVlJBTTogMTI4TSAweDc4MDAwMDAwIC0gMHg3RkZGRkZGRiAo MTI4TSB1c2VkKQogICAgICAgIHJhZGVvbiAwMDAwOjAxOjA1LjA6IEdUVDogNTEyTSAweDgwMDAw MDAwIC0gMHg5RkZGRkZGRgogICAgICAgIFtkcm1dIHJhZGVvbjogaXJxIGluaXRpYWxpemVkLgog ICAgICAgIFtkcm1dIERldGVjdGVkIFZSQU0gUkFNPTEyOE0sIEJBUj0xMjhNCiAgICAgICAgW2Ry bV0gUkFNIHdpZHRoIDEyOGJpdHMgRERSCiAgICAgICAgW1RUTV0gWm9uZSAga2VybmVsOiBBdmFp bGFibGUgZ3JhcGhpY3MgbWVtb3J5OiA5NjMwMjIga2lCLgogICAgICAgIFtUVE1dIEluaXRpYWxp emluZyBwb29sIGFsbG9jYXRvci4KICAgICAgICBbZHJtXSByYWRlb246IDEyOE0gb2YgVlJBTSBt ZW1vcnkgcmVhZHkKICAgICAgICBbZHJtXSByYWRlb246IDUxMk0gb2YgR1RUIG1lbW9yeSByZWFk eS4KICAgICAgICBbZHJtXSBHQVJUOiBudW0gY3B1IHBhZ2VzIDEzMTA3MiwgbnVtIGdwdSBwYWdl cyAxMzEwNzIKICAgICAgICBbZHJtXSByYWRlb246IDEgcXVhZCBwaXBlcywgMSB6IHBpcGVzIGlu aXRpYWxpemVkLgogICAgICAgIFtkcm1dIExvYWRpbmcgUlM2OTAvUlM3NDAgTWljcm9jb2RlCiAg ICAgICAgW2RybV0gcmFkZW9uOiByaW5nIGF0IDB4MDAwMDAwMDA4MDAwMDAwMAogICAgICAgIFtk cm1dIHJpbmcgdGVzdCBzdWNjZWVkZWQgaW4gMSB1c2VjcwogICAgICAgIFtkcm1dIHJhZGVvbjog aWIgcG9vbCByZWFkeS4KICAgICAgICBbZHJtXSBpYiB0ZXN0IHN1Y2NlZWRlZCBpbiAwIHVzZWNz CiAgICAgICAgW2RybV0gRW5hYmxpbmcgYXVkaW8gc3VwcG9ydAogICAgICAgIGZhaWxlZCB0byBl dmFsdWF0ZSBBVElGIGdvdCBBRV9CQURfUEFSQU1FVEVSCiAgICAgICAgW2RybV0gRGVmYXVsdCBU ViBzdGFuZGFyZDogTlRTQwogICAgICAgIFtkcm1dIFJhZGVvbiBEaXNwbGF5IENvbm5lY3RvcnMK ICAgICAgICBbZHJtXSBDb25uZWN0b3IgMDoKICAgICAgICBbZHJtXSAgIFZHQQogICAgICAgIFtk cm1dICAgRERDOiAweDdlNTAgMHg3ZTQwIDB4N2U1NCAweDdlNDQgMHg3ZTU4IDB4N2U0OCAweDdl NWMgMHg3ZTRjCiAgICAgICAgW2RybV0gICBFbmNvZGVyczoKICAgICAgICBbZHJtXSAgICAgQ1JU MTogSU5URVJOQUxfS0xEU0NQX0RBQzEKICAgICAgICBbZHJtXSBmYiBtYXBwYWJsZSBhdCAweEQ4 MDQwMDAwCiAgICAgICAgW2RybV0gdnJhbSBhcHBlciBhdCAweEQ4MDAwMDAwCiAgICAgICAgW2Ry bV0gc2l6ZSA0MzI1Mzc2CiAgICAgICAgW2RybV0gZmIgZGVwdGggaXMgMjQKICAgICAgICBbZHJt XSAgICBwaXRjaCBpcyA1NjMyCiAgICAgICAgZmJjb246IHJhZGVvbmRybWZiIChmYjApIGlzIHBy aW1hcnkgZGV2aWNlCiAgICAgICAgQ29uc29sZTogc3dpdGNoaW5nIHRvIGNvbG91ciBmcmFtZSBi dWZmZXIgZGV2aWNlIDE3MHg0OAogICAgICAgIGZiMDogcmFkZW9uZHJtZmIgZnJhbWUgYnVmZmVy IGRldmljZQogICAgICAgIGRybTogcmVnaXN0ZXJlZCBwYW5pYyBub3RpZmllcgogICAgICAgIFNs b3cgd29yayB0aHJlYWQgcG9vbDogU3RhcnRpbmcgdXAKICAgICAgICBTbG93IHdvcmsgdGhyZWFk IHBvb2w6IFJlYWR5CiAgICAgICAgW2RybV0gSW5pdGlhbGl6ZWQgcmFkZW9uIDIuNi4wIDIwMDgw NTI4IGZvciAwMDAwOjAxOjA1LjAgb24gbWlub3IgMAoKCkJ5IGluc3BlY3Rpb24gb2YgdGhlIGNv ZGUsIGl0IGxvb2tzIGxpa2UgdGhlIGhhbmRsZSBiZWluZyBwYXNzZWQgaW50bwpyYWRlb25fYXRp Zl9jYWxsKCkgYnkgcmFkZW9uX2FjcGlfaW5pdCgpIG1heSBiZSBiYWQuICBJJ20gbm90IHN1cmUg d2h5CnRoYXQgd291bGQgYmUgdGhvdWdoLgoKSSB3b24ndCBoYXZlIHRpbWUgdW50aWwgVGh1cnNk YXkgdG8gcnVuIGl0IGRvd24gYW55IGZ1cnRoZXIuCgpSZWdhcmRzLApBbmR5Cgo+IFRoYW5rcywK PiAKPiBBbGV4CgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3Jn Cmh0dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK