From: Johannes Berg <johannes@sipsolutions.net>
To: Luciano Coelho <luciano.coelho@nokia.com>
Cc: linux-wireless@vger.kernel.org,
Juuso Oikarinen <juuso.oikarinen@nokia.com>
Subject: Re: [PATCH 16/25] wl1271: Add support for hardware GEM cipher
Date: Mon, 27 Sep 2010 11:12:57 +0200 [thread overview]
Message-ID: <1285578777.4043.6.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <1285576669-8070-17-git-send-email-luciano.coelho@nokia.com>
On Mon, 2010-09-27 at 11:37 +0300, Luciano Coelho wrote:
> From: Juuso Oikarinen <juuso.oikarinen@nokia.com>
>
> This patch adds support for the hardware GEM cipher suite.
>
> Signed-off-by: Juuso Oikarinen <juuso.oikarinen@nokia.com>
> Reviewed-by: Luciano Coelho <luciano.coelho@nokia.com>
> Signed-off-by: Luciano Coelho <luciano.coelho@nokia.com>
> ---
> drivers/net/wireless/wl12xx/wl1271.h | 2 ++
> drivers/net/wireless/wl12xx/wl1271_cmd.h | 2 +-
> drivers/net/wireless/wl12xx/wl1271_main.c | 16 ++++++++++++++++
> 3 files changed, 19 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/net/wireless/wl12xx/wl1271.h b/drivers/net/wireless/wl12xx/wl1271.h
> index 763ece8..9782bc1 100644
> --- a/drivers/net/wireless/wl12xx/wl1271.h
> +++ b/drivers/net/wireless/wl12xx/wl1271.h
> @@ -117,6 +117,8 @@ enum {
> #define WL1271_TX_SECURITY_LO16(s) ((u16)((s) & 0xffff))
> #define WL1271_TX_SECURITY_HI32(s) ((u32)(((s) >> 16) & 0xffffffff))
>
> +#define WL1271_CIPHER_SUITE_GEM 0x000FACFF
NACK, this is a standards-reserved value. Use the correct ID for it or
allocate one within your own OUI if you don't want to admit what this
really is (and by now all readers here will know anyway.)
johannes
next prev parent reply other threads:[~2010-09-27 9:12 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-27 8:37 [PATCH 00/25] wl1271: pending patches Luciano Coelho
2010-09-27 8:37 ` [PATCH 01/25] wl1271: remove deprecated ACX definition Luciano Coelho
2010-09-27 8:37 ` [PATCH 02/25] wl1271: Implement CMD_SET_STA_STATE to indicate connection completion to FW Luciano Coelho
2010-09-27 8:37 ` [PATCH 03/25] wl1271: Add trigger to net_device oper_state to change BT coex priority Luciano Coelho
2010-09-27 8:37 ` [PATCH 04/25] wl1271: Fix scan race condition Luciano Coelho
2010-09-27 8:37 ` [PATCH 05/25] wl1271: remove useless 11a check when scanning Luciano Coelho
2010-09-27 8:37 ` [PATCH 06/25] wl1271: fix forced passive scan Luciano Coelho
2010-09-27 8:37 ` [PATCH 07/25] wl1271: Change supported channel order for a more optimal scan Luciano Coelho
2010-09-27 8:48 ` Johannes Berg
2010-09-27 10:50 ` Luciano Coelho
2010-09-27 8:37 ` [PATCH 08/25] wl1271: Remove outdated FIXME's Luciano Coelho
2010-09-27 8:37 ` [PATCH 09/25] wl1271: Move setting of wake-up conditions to ps.c from cmd.c Luciano Coelho
2010-09-27 8:37 ` [PATCH 10/25] wl1271: Remove acx_fw_version function Luciano Coelho
2010-09-27 8:37 ` [PATCH 11/25] wl1271: Release interrupt *after* releasing the driver context Luciano Coelho
2010-09-27 8:37 ` [PATCH 12/25] wl1271: Remove function cmd_read_memory Luciano Coelho
2010-09-27 8:37 ` [PATCH 13/25] wl1271: Enable/disable 11a support based on INI configuration Luciano Coelho
2010-10-06 5:26 ` Gabay, Benzy
2010-10-06 5:36 ` Juuso Oikarinen
2010-10-06 6:19 ` Gabay, Benzy
2010-09-27 8:37 ` [PATCH 14/25] wl1271: Reduce rate used for last PSM entry attempt Luciano Coelho
2010-09-27 8:37 ` [PATCH 15/25] wl1271: Enable 11a support always, prevent scanning for unsupporting chips Luciano Coelho
2010-09-27 8:37 ` [PATCH 16/25] wl1271: Add support for hardware GEM cipher Luciano Coelho
2010-09-27 9:12 ` Johannes Berg [this message]
2010-09-27 9:46 ` Juuso Oikarinen
2010-09-27 9:49 ` Johannes Berg
2010-09-27 9:58 ` Juuso Oikarinen
2010-09-27 10:01 ` Luciano Coelho
2010-09-27 10:42 ` [PATCHv2] " juuso.oikarinen
2010-09-27 8:37 ` [PATCH 17/25] wl1271: Fix tid-configuration of TX frames Luciano Coelho
2010-09-27 8:51 ` Johannes Berg
2010-09-27 8:57 ` Juuso Oikarinen
2010-09-27 8:37 ` [PATCH 18/25] wl1271: Fix AC/TID default configuration Luciano Coelho
2010-09-27 8:37 ` [PATCH 19/25] wl1271: Move scan complete invocation into work function Luciano Coelho
2010-09-27 8:37 ` [PATCH 20/25] wl1271: Fix work cancelling when shutting down the driver Luciano Coelho
2010-09-27 8:37 ` [PATCH 21/25] wl1271: Separate interface removal to another function Luciano Coelho
2010-09-27 8:37 ` [PATCH 22/25] wl1271: Add hardware recovery mechanism Luciano Coelho
2010-09-27 8:37 ` [PATCH 23/25] wl1271: Add handling for failing hardware scan command Luciano Coelho
2010-09-27 8:37 ` [PATCH 24/25] wl1271: Optimize scan duration Luciano Coelho
2010-10-05 5:30 ` Gabay, Benzy
2010-10-05 5:40 ` Juuso Oikarinen
2010-10-05 15:42 ` Gabay, Benzy
2010-10-06 4:59 ` Juuso Oikarinen
2010-10-06 5:21 ` Gabay, Benzy
2010-10-06 5:26 ` Juuso Oikarinen
2010-10-06 5:50 ` Gabay, Benzy
2010-09-27 8:37 ` [PATCH 25/25] wl1271: Increase connection reliability Luciano Coelho
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1285578777.4043.6.camel@jlt3.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=juuso.oikarinen@nokia.com \
--cc=linux-wireless@vger.kernel.org \
--cc=luciano.coelho@nokia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.