From: Johannes Berg <johannes@sipsolutions.net>
To: "John W. Linville" <linville@tuxdriver.com>
Cc: Wey-Yi Guy <wey-yi.w.guy@intel.com>,
greg@kroah.com, linux-wireless@vger.kernel.org,
ipw3945-devel@lists.sourceforge.net
Subject: Re: [PATCH wireless-2.6.35] use long timer for un-necessary reload the firmware
Date: Mon, 27 Sep 2010 12:55:53 +0200 [thread overview]
Message-ID: <1285584953.4043.17.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <20100924191713.GF8077@tuxdriver.com>
On Fri, 2010-09-24 at 15:17 -0400, John W. Linville wrote:
> On Thu, Sep 23, 2010 at 02:04:24PM -0700, Wey-Yi Guy wrote:
> > Different devices has different timing requirement, change the timeout
> > value for 5000 series devices to avoid un-necessary firmware reload which
> > can cause device become unstable.For 5000 series of devices, use long monitor timer to check
> > stuck tx queues.
> >
> > It is being reported firmware got reload more
> > often than necessary, so extend the timer to avoid un-necessary reload.
> >
> > This fixes:
> > http://article.gmane.org/gmane.linux.kernel.wireless.general/53552
> >
> > Cc: stable@kernel.org [2.6.35]
> So then I try applying it directly...
>
> [linville-8530p.local]:> git am -s fixes.mbox
> Applying: use long timer for un-necessary reload the firmware
> error: patch failed: drivers/net/wireless/iwlwifi/iwl-1000.c:257
Actually, I believe you weren't meant to apply this, this looks like a
backport of
commit 78e1e688a404573a6788abbddfe2f4631d833bca
Author: Wey-Yi Guy <wey-yi.w.guy@intel.com>
Date: Fri Jul 23 13:19:39 2010 -0700
iwlwifi: long monitor timer
to stable-2.6.35, since the original commit had no cc: stable tag.
johannes
next prev parent reply other threads:[~2010-09-27 10:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-23 21:04 [PATCH wireless-2.6.35] use long timer for un-necessary reload the firmware Wey-Yi Guy
2010-09-24 19:17 ` John W. Linville
2010-09-27 10:55 ` Johannes Berg [this message]
2010-09-27 12:34 ` John W. Linville
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1285584953.4043.17.camel@jlt3.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=greg@kroah.com \
--cc=ipw3945-devel@lists.sourceforge.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=wey-yi.w.guy@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.