All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ben Hutchings <bhutchings@solarflare.com>
To: xiaohui.xin@intel.com
Cc: netdev@vger.kernel.org, kvm@vger.kernel.org,
	linux-kernel@vger.kernel.org, mingo@elte.hu, davem@davemloft.net,
	herbert@gondor.hengli.com.au, jdike@linux.intel.com
Subject: Re: [PATCH v11 03/17] Add a ndo_mp_port_prep pointer to net_device_ops.
Date: Mon, 27 Sep 2010 14:42:33 +0100	[thread overview]
Message-ID: <1285594953.2263.5.camel@achroite.uk.solarflarecom.com> (raw)
In-Reply-To: <79267b300503d98d43ccfcf11d1374f59fec8578.1285385607.git.xiaohui.xin@intel.com>

On Sat, 2010-09-25 at 12:27 +0800, xiaohui.xin@intel.com wrote:
> From: Xin Xiaohui <xiaohui.xin@intel.com>
> 
> If the driver want to allocate external buffers,
> then it can export it's capability, as the skb
> buffer header length, the page length can be DMA, etc.
> The external buffers owner may utilize this.
[...]

This information needs to be included in the comment above struct
net_device_ops, not just in the commit message.

Ben.

-- 
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.


  reply	other threads:[~2010-09-27 13:42 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-25  4:27 [PATCH v11 00/17] Provide a zero-copy method on KVM virtio-net xiaohui.xin
2010-09-25  4:27 ` [PATCH v11 01/17] Add a new structure for skb buffer from external xiaohui.xin
2010-09-25  4:27   ` [PATCH v11 02/17] Add a new struct for device to manipulate external buffer xiaohui.xin
2010-09-27 13:41     ` Ben Hutchings
2010-09-25  4:27   ` [PATCH v11 03/17] Add a ndo_mp_port_prep pointer to net_device_ops xiaohui.xin
2010-09-27 13:42     ` Ben Hutchings [this message]
2010-09-29 13:41       ` Xin, Xiaohui
2010-09-25  4:27   ` [PATCH v11 04/17]Add a function make external buffer owner to query capability xiaohui.xin
2010-09-27 13:45     ` Ben Hutchings
2010-09-25  4:27   ` [PATCH v11 05/17] Add a function to indicate if device use external buffer xiaohui.xin
2010-09-25  4:27   ` [PATCH v11 06/17]Use callback to deal with skb_release_data() specially xiaohui.xin
2010-09-25  4:27   ` [PATCH v11 07/17] Modify netdev_alloc_page() to get external buffer xiaohui.xin
2010-09-25  4:27   ` [PATCH v11 08/17] Modify netdev_free_page() to release " xiaohui.xin
2010-09-25  4:27   ` [PATCH v11 09/17] Don't do skb recycle, if device use " xiaohui.xin
2010-09-25  4:27   ` [PATCH v11 10/17] Add a hook to intercept external buffers from NIC driver xiaohui.xin
2010-09-25  4:27   ` [PATCH v11 11/17] Add header file for mp device xiaohui.xin
2010-09-27 13:55     ` Ben Hutchings
2010-09-25  4:27   ` [PATCH v11 12/17] Add a kconfig entry and make entry " xiaohui.xin
2010-09-27 13:56     ` Ben Hutchings
2010-09-29 13:39       ` Xin, Xiaohui
2010-09-25  4:27   ` [PATCH v11 13/17] Add mp(mediate passthru) device xiaohui.xin
2010-09-27 21:23     ` Ben Hutchings
2010-09-28 13:06       ` Michael S. Tsirkin
2010-09-28 14:39         ` Arnd Bergmann
2010-09-28 14:43           ` Michael S. Tsirkin
2010-09-28 15:18             ` Arnd Bergmann
2010-09-28 18:48               ` Sridhar Samudrala
2010-09-29 13:38       ` Xin, Xiaohui
2010-09-25  4:27   ` [PATCH v11 14/17]Provides multiple submits and asynchronous notifications xiaohui.xin
2010-09-25  4:27   ` [PATCH v11 15/17]An example how to modifiy NIC driver to use napi_gro_frags() interface xiaohui.xin
2010-09-25  4:27   ` [PATCH v11 16/17]An example how to alloc user buffer based on " xiaohui.xin
2010-09-25  4:27   ` [PATCH v11 17/17]add two new ioctls for mp device xiaohui.xin
2010-09-27 21:36     ` Ben Hutchings
2010-09-28 13:09       ` Michael S. Tsirkin
2010-09-28  9:48     ` Michael S. Tsirkin
2010-09-29  9:36       ` xiaohui.xin
2010-09-26 17:01 ` [PATCH v11 00/17] Provide a zero-copy method on KVM virtio-net Michael S. Tsirkin
2010-09-27  0:44   ` Xin, Xiaohui
2010-09-28  1:25     ` Xin, Xiaohui

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1285594953.2263.5.camel@achroite.uk.solarflarecom.com \
    --to=bhutchings@solarflare.com \
    --cc=davem@davemloft.net \
    --cc=herbert@gondor.hengli.com.au \
    --cc=jdike@linux.intel.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=netdev@vger.kernel.org \
    --cc=xiaohui.xin@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.