From: Nikhil Rao <ncrao@google.com>
To: Ingo Molnar <mingo@elte.hu>,
Peter Zijlstra <peterz@infradead.org>,
Mike Galbraith <efault@gmx.de>
Cc: Venkatesh Pallipadi <venki@google.com>,
linux-kernel@vger.kernel.org, Nikhil Rao <ncrao@google.com>
Subject: [PATCH 3/3] sched: do not consider SCHED_IDLE tasks to be cache hot
Date: Mon, 27 Sep 2010 17:29:58 -0700 [thread overview]
Message-ID: <1285633798-26886-4-git-send-email-ncrao@google.com> (raw)
In-Reply-To: <1285633798-26886-1-git-send-email-ncrao@google.com>
This patch adds a check in task_hot to return if the task has SCHED_IDLE
policy. SCHED_IDLE tasks have very low weight, and when run with regular
weight tasks, are typically scheduled many milliseconds apart. There is no
benefit from considering SCHED_IDLE tasks cache hot for load balancing.
Signed-off-by: Nikhil Rao <ncrao@google.com>
---
kernel/sched.c | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/kernel/sched.c b/kernel/sched.c
index ed09d4f..874efde 100644
--- a/kernel/sched.c
+++ b/kernel/sched.c
@@ -2003,6 +2003,9 @@ task_hot(struct task_struct *p, u64 now, struct sched_domain *sd)
if (p->sched_class != &fair_sched_class)
return 0;
+ if (p->policy == SCHED_IDLE)
+ return 0;
+
/*
* Buddy candidates are cache hot:
*/
--
1.7.1
next prev parent reply other threads:[~2010-09-28 0:30 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-28 0:29 [PATCH 0/3][RFC] Improve load balancing when tasks have large weight differential Nikhil Rao
2010-09-28 0:29 ` [PATCH 1/3] sched: set group_imb only a task can be pulled from the busiest cpu Nikhil Rao
2010-09-28 0:29 ` [PATCH 2/3] sched: drop group_capacity to 1 only if remote group has no running tasks Nikhil Rao
2010-09-28 23:04 ` Suresh Siddha
2010-10-11 21:20 ` Nikhil Rao
2010-09-28 0:29 ` Nikhil Rao [this message]
2010-09-28 13:57 ` [PATCH 0/3][RFC] Improve load balancing when tasks have large weight differential Mike Galbraith
2010-09-28 21:15 ` Nikhil Rao
2010-09-29 1:45 ` Mike Galbraith
2010-09-29 19:32 ` Nikhil Rao
2010-10-04 3:08 ` Mike Galbraith
2010-10-06 8:23 ` Nikhil Rao
2010-10-08 7:22 ` Mike Galbraith
2010-10-08 20:34 ` Nikhil Rao
2010-10-10 10:15 ` Mike Galbraith
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1285633798-26886-4-git-send-email-ncrao@google.com \
--to=ncrao@google.com \
--cc=efault@gmx.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=peterz@infradead.org \
--cc=venki@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.