From: Huang Ying <ying.huang@intel.com>
To: Len Brown <lenb@kernel.org>
Cc: linux-kernel@vger.kernel.org, Andi Kleen <andi@firstfloor.org>,
linux-acpi@vger.kernel.org,
Jin Dongming <jin.dongming@np.css.fujitsu.com>,
Huang Ying <ying.huang@intel.com>
Subject: [PATCH -v2 2/5] ACPI, APEI, Fix acpi_pre_map() return value
Date: Wed, 29 Sep 2010 19:53:52 +0800 [thread overview]
Message-ID: <1285761235-4751-3-git-send-email-ying.huang@intel.com> (raw)
In-Reply-To: <1285761235-4751-1-git-send-email-ying.huang@intel.com>
From: Jin Dongming <jin.dongming@np.css.fujitsu.com>
After we ioremap() a new region, we call __acpi_try_ioremap() to
see whether another thread has already mapped the same region.
This check clobbers "vaddr", so compute the return value of
acpi_pre_map() using the ioremap() result "map->vaddr" instead.
v2:
Modified the unsuitable description of patch.
v3:
Removed unlikely() check and made description simpler.
Signed-off-by: Jin Dongming <jin.dongming@np.css.fujitsu.com>
Reviewed-by: Andi Kleen <ak@linux.intel.com>
Signed-off-by: Huang Ying <ying.huang@intel.com>
---
drivers/acpi/atomicio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/drivers/acpi/atomicio.c
+++ b/drivers/acpi/atomicio.c
@@ -142,7 +142,7 @@ static void __iomem *acpi_pre_map(phys_a
list_add_tail_rcu(&map->list, &acpi_iomaps);
spin_unlock_irqrestore(&acpi_iomaps_lock, flags);
- return vaddr + (paddr - pg_off);
+ return map->vaddr + (paddr - map->paddr);
err_unmap:
iounmap(vaddr);
return NULL;
next prev parent reply other threads:[~2010-09-29 11:53 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-29 11:53 [PATCH -v2 0/5] ACPI, APEI, BUG fixes for 2.6.36 Huang Ying
2010-09-29 11:53 ` [PATCH -v2 1/5] ACPI, APEI, Fix APEI related table size checking Huang Ying
2010-09-29 15:47 ` Yinghai Lu
2010-09-30 0:11 ` Huang Ying
2010-09-29 18:01 ` Len Brown
2010-09-30 0:25 ` Huang Ying
2010-09-29 18:10 ` Len Brown
2010-09-29 11:53 ` Huang Ying [this message]
2010-09-29 18:11 ` [PATCH -v2 2/5] ACPI, APEI, Fix acpi_pre_map() return value Len Brown
2010-09-29 11:53 ` [PATCH -v2 3/5] ACPI, APEI, HEST Fix the unsuitable usage of platform_data Huang Ying
2010-09-29 18:11 ` Len Brown
2010-09-29 11:53 ` [PATCH -v2 4/5] ACPI, APEI, Fix error path for memory allocation Huang Ying
2010-09-29 18:11 ` Len Brown
2010-09-29 11:53 ` [PATCH -v2 5/5] ACPI, APEI, Fix ERST MOVE_DATA instruction implementation Huang Ying
2010-09-29 18:12 ` Len Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1285761235-4751-3-git-send-email-ying.huang@intel.com \
--to=ying.huang@intel.com \
--cc=andi@firstfloor.org \
--cc=jin.dongming@np.css.fujitsu.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.