From: Johannes Berg <johannes@sipsolutions.net>
To: Ben Greear <greearb@candelatech.com>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH v3] mac80211: Allow scanning single channel if other VIF is associated.
Date: Wed, 29 Sep 2010 19:03:56 +0200 [thread overview]
Message-ID: <1285779836.3756.26.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <4CA3704E.1070702@candelatech.com>
On Wed, 2010-09-29 at 09:58 -0700, Ben Greear wrote:
> >> + if (!(wk->chan == local->scan_channel ||
> >> + (wk->chan == local->oper_channel&&
> >
> > I don't think work items will ever run while scanning? And also, this
> > might need to check the channel type as well, which isn't quite
> > necessary right now (since no works requires HT channels) but would seem
> > cleaner.
>
> Just in case work ever does happen when scanning, I think we should
> leave this check in.
I think we'll have bigger problems if that happens, since scanning will
switch away from the channel again quickly, likely before the work
finishes. I'd rather add an assertion that it _doesn't_ happen, I think.
johannes
next prev parent reply other threads:[~2010-09-29 17:03 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-28 21:17 [PATCH v3] mac80211: Allow scanning single channel if other VIF is associated greearb
2010-09-29 7:02 ` Johannes Berg
2010-09-29 15:30 ` Ben Greear
2010-09-29 16:48 ` Johannes Berg
2010-09-29 16:58 ` Ben Greear
2010-09-29 17:03 ` Johannes Berg [this message]
2010-09-29 17:44 ` Ben Greear
2010-09-29 18:05 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1285779836.3756.26.camel@jlt3.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=greearb@candelatech.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.