From: Artem Bityutskiy <dedekind1@gmail.com>
To: Mike Frysinger <vapier@gentoo.org>
Cc: linux-mtd@lists.infradead.org
Subject: Re: [PATCH 1/3] mtd-utils: new memory wrappers
Date: Thu, 30 Sep 2010 09:01:39 +0300 [thread overview]
Message-ID: <1285826499.11684.24.camel@localhost> (raw)
In-Reply-To: <AANLkTi=E6qy2sBq1thXMUWfxSbCuNZDUOmmGT8o0j0hW@mail.gmail.com>
On Thu, 2010-09-30 at 01:59 -0400, Mike Frysinger wrote:
> On Thu, Sep 30, 2010 at 01:48, Artem Bityutskiy wrote:
> > On Thu, 2010-09-30 at 01:15 -0400, Mike Frysinger wrote:
> >> as i'm sure you noticed, i didnt make these up. i simply moved them
> >> from existing mtd-utils code.
> >
> > Actually no, I did not notice!
>
> np ... only one or two utils uses this, and easy enough to convert
> them. before i go further though, a question on direction ...
>
> mkfs.jffs2 has a lot of helpers that can be moved to common.h. but it
> implements things using C functions & va_args. the common.h header
> takes the CPP approach of expanding the variable args. which way to
> go to ultimately unify the code base !?
I have not strong opinion, how about creating common.c ?
--
Best Regards,
Artem Bityutskiy (Артём Битюцкий)
next prev parent reply other threads:[~2010-09-30 6:03 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-29 23:30 [PATCH 1/3] mtd-utils: new memory wrappers Mike Frysinger
2010-09-29 23:30 ` [PATCH 2/3] mtd-utils: add xasprintf() helper Mike Frysinger
2010-09-30 5:28 ` Mike Frysinger
2010-09-29 23:30 ` [PATCH 3/3] mkfs.jffs2: use new " Mike Frysinger
2010-09-30 4:59 ` [PATCH 1/3] mtd-utils: new memory wrappers Artem Bityutskiy
2010-09-30 5:15 ` Mike Frysinger
2010-09-30 5:48 ` Artem Bityutskiy
2010-09-30 5:59 ` Mike Frysinger
2010-09-30 6:01 ` Artem Bityutskiy [this message]
2010-09-30 6:18 ` Mike Frysinger
2010-09-30 6:56 ` Artem Bityutskiy
2010-10-01 0:47 ` Mike Frysinger
2010-10-01 1:43 ` Mike Frysinger
2010-09-30 5:27 ` [PATCH 1/3 v2] " Mike Frysinger
2010-09-30 5:54 ` Artem Bityutskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1285826499.11684.24.camel@localhost \
--to=dedekind1@gmail.com \
--cc=linux-mtd@lists.infradead.org \
--cc=vapier@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.