All of lore.kernel.org
 help / color / mirror / Atom feed
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Trond Myklebust <trond.myklebust@fys.uio.no>
Cc: Nick Piggin <npiggin@kernel.dk>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Al Viro <viro@ZenIV.linux.org.uk>,
	linux-fsdevel@vger.kernel.org
Subject: Re: Odd NFS related SIGBUS (& possible fix)
Date: Sat, 02 Oct 2010 06:53:27 +1000	[thread overview]
Message-ID: <1285966407.2463.145.camel@pasglop> (raw)
In-Reply-To: <1285956768.30373.39.camel@heimdal.trondhjem.org>

On Fri, 2010-10-01 at 14:12 -0400, Trond Myklebust wrote:
> 
> However, it looks to me as if the right thing to do when the
> page->mapping has changed would be to do the same thing as
> block_page_mkwrite(), and just return VM_FAULT_NOPAGE so that the VM
> can
> retry the fault.
> IMO: We should only SIGBUS if the calls to nfs_flush_incompatible()
> and/or nfs_updatepage() fail.

Well, other filesystems seem to think that if the mapping -changed-,
SIGBUS is a good idea... But they don't have to deal with invalidations
wiping mappings in the background.

So that's why I was thinking about singling out the "mapping became
NULL" case and keep the SIGBUS for when the mapping became something
else... but that's your call really :-)

Cheers,
Ben.


      parent reply	other threads:[~2010-10-01 20:53 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-29  4:33 Odd NFS related SIGBUS (& possible fix) Benjamin Herrenschmidt
2010-09-29  7:44 ` Benjamin Herrenschmidt
2010-10-01  5:57 ` Benjamin Herrenschmidt
2010-10-01  5:57   ` Benjamin Herrenschmidt
2010-10-01  6:01   ` Benjamin Herrenschmidt
2010-10-01  6:01     ` Benjamin Herrenschmidt
2010-10-01 17:18   ` J. Bruce Fields
2010-10-01 18:12 ` Trond Myklebust
2010-10-01 18:35   ` Trond Myklebust
2010-10-01 20:57     ` Benjamin Herrenschmidt
2010-10-18 23:43       ` Benjamin Herrenschmidt
2010-10-01 20:53   ` Benjamin Herrenschmidt [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1285966407.2463.145.camel@pasglop \
    --to=benh@kernel.crashing.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=npiggin@kernel.dk \
    --cc=trond.myklebust@fys.uio.no \
    --cc=viro@ZenIV.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.