From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from e5.ny.us.ibm.com (e5.ny.us.ibm.com [32.97.182.145]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "e5.ny.us.ibm.com", Issuer "Equifax" (verified OK)) by ozlabs.org (Postfix) with ESMTPS id 9040AB6F07 for ; Mon, 4 Oct 2010 05:11:08 +1100 (EST) Received: from d01relay07.pok.ibm.com (d01relay07.pok.ibm.com [9.56.227.147]) by e5.ny.us.ibm.com (8.14.4/8.13.1) with ESMTP id o93Hopdn004303 for ; Sun, 3 Oct 2010 13:50:51 -0400 Received: from d01av04.pok.ibm.com (d01av04.pok.ibm.com [9.56.224.64]) by d01relay07.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id o93IB4LU2257076 for ; Sun, 3 Oct 2010 14:11:04 -0400 Received: from d01av04.pok.ibm.com (loopback [127.0.0.1]) by d01av04.pok.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id o93IB39F002097 for ; Sun, 3 Oct 2010 14:11:04 -0400 Subject: Re: [PATCH 7/9] v3 Define memory_block_size_bytes for powerpc/pseries From: Dave Hansen To: Robin Holt In-Reply-To: <20101003180731.GT14064@sgi.com> References: <4CA62700.7010809@austin.ibm.com> <4CA62A0A.4050406@austin.ibm.com> <20101003175500.GE7896@balbir.in.ibm.com> <20101003180731.GT14064@sgi.com> Content-Type: text/plain; charset="ANSI_X3.4-1968" Date: Sun, 03 Oct 2010 11:11:01 -0700 Message-ID: <1286129461.9970.1.camel@nimitz> Mime-Version: 1.0 Cc: Greg KH , steiner@sgi.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linuxppc-dev@lists.ozlabs.org, KAMEZAWA Hiroyuki , Balbir Singh List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Sun, 2010-10-03 at 13:07 -0500, Robin Holt wrote: > On Sun, Oct 03, 2010 at 11:25:00PM +0530, Balbir Singh wrote: > > * Nathan Fontenot [2010-10-01 13:35:54]: > > > > > Define a version of memory_block_size_bytes() for powerpc/pseries such that > > > a memory block spans an entire lmb. > > > > I hope I am not missing anything obvious, but why not just call it > > lmb_size, why do we need memblock_size? > > > > Is lmb_size == memblock_size after your changes true for all > > platforms? > > What is an lmb? I don't recall anything like lmb being referred to in > the rest of the kernel. Heh. It's the OpenFirmware name for a Logical Memory Block. Basically what we use to determine the SECTION_SIZE on powerpc. Probably not the best terminology to use elsewhere in the kernel. -- Dave From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754344Ab0JCSLJ (ORCPT ); Sun, 3 Oct 2010 14:11:09 -0400 Received: from e3.ny.us.ibm.com ([32.97.182.143]:47656 "EHLO e3.ny.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754377Ab0JCSLF (ORCPT ); Sun, 3 Oct 2010 14:11:05 -0400 Subject: Re: [PATCH 7/9] v3 Define memory_block_size_bytes for powerpc/pseries From: Dave Hansen To: Robin Holt Cc: Balbir Singh , Nathan Fontenot , linux-kernel@vger.kernel.org, linux-mm@kvack.org, linuxppc-dev@lists.ozlabs.org, Greg KH , KAMEZAWA Hiroyuki , steiner@sgi.com In-Reply-To: <20101003180731.GT14064@sgi.com> References: <4CA62700.7010809@austin.ibm.com> <4CA62A0A.4050406@austin.ibm.com> <20101003175500.GE7896@balbir.in.ibm.com> <20101003180731.GT14064@sgi.com> Content-Type: text/plain; charset="ANSI_X3.4-1968" Date: Sun, 03 Oct 2010 11:11:01 -0700 Message-ID: <1286129461.9970.1.camel@nimitz> Mime-Version: 1.0 X-Mailer: Evolution 2.28.1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 2010-10-03 at 13:07 -0500, Robin Holt wrote: > On Sun, Oct 03, 2010 at 11:25:00PM +0530, Balbir Singh wrote: > > * Nathan Fontenot [2010-10-01 13:35:54]: > > > > > Define a version of memory_block_size_bytes() for powerpc/pseries such that > > > a memory block spans an entire lmb. > > > > I hope I am not missing anything obvious, but why not just call it > > lmb_size, why do we need memblock_size? > > > > Is lmb_size == memblock_size after your changes true for all > > platforms? > > What is an lmb? I don't recall anything like lmb being referred to in > the rest of the kernel. Heh. It's the OpenFirmware name for a Logical Memory Block. Basically what we use to determine the SECTION_SIZE on powerpc. Probably not the best terminology to use elsewhere in the kernel. -- Dave From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail172.messagelabs.com (mail172.messagelabs.com [216.82.254.3]) by kanga.kvack.org (Postfix) with ESMTP id 3E5C16B0085 for ; Sun, 3 Oct 2010 14:11:06 -0400 (EDT) Received: from d01relay05.pok.ibm.com (d01relay05.pok.ibm.com [9.56.227.237]) by e6.ny.us.ibm.com (8.14.4/8.13.1) with ESMTP id o93IBL7C031512 for ; Sun, 3 Oct 2010 14:11:21 -0400 Received: from d01av04.pok.ibm.com (d01av04.pok.ibm.com [9.56.224.64]) by d01relay05.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id o93IB41I128510 for ; Sun, 3 Oct 2010 14:11:04 -0400 Received: from d01av04.pok.ibm.com (loopback [127.0.0.1]) by d01av04.pok.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id o93IB39B002097 for ; Sun, 3 Oct 2010 14:11:04 -0400 Subject: Re: [PATCH 7/9] v3 Define memory_block_size_bytes for powerpc/pseries From: Dave Hansen In-Reply-To: <20101003180731.GT14064@sgi.com> References: <4CA62700.7010809@austin.ibm.com> <4CA62A0A.4050406@austin.ibm.com> <20101003175500.GE7896@balbir.in.ibm.com> <20101003180731.GT14064@sgi.com> Content-Type: text/plain; charset="ANSI_X3.4-1968" Date: Sun, 03 Oct 2010 11:11:01 -0700 Message-ID: <1286129461.9970.1.camel@nimitz> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org To: Robin Holt Cc: Balbir Singh , Nathan Fontenot , linux-kernel@vger.kernel.org, linux-mm@kvack.org, linuxppc-dev@lists.ozlabs.org, Greg KH , KAMEZAWA Hiroyuki , steiner@sgi.com List-ID: On Sun, 2010-10-03 at 13:07 -0500, Robin Holt wrote: > On Sun, Oct 03, 2010 at 11:25:00PM +0530, Balbir Singh wrote: > > * Nathan Fontenot [2010-10-01 13:35:54]: > > > > > Define a version of memory_block_size_bytes() for powerpc/pseries such that > > > a memory block spans an entire lmb. > > > > I hope I am not missing anything obvious, but why not just call it > > lmb_size, why do we need memblock_size? > > > > Is lmb_size == memblock_size after your changes true for all > > platforms? > > What is an lmb? I don't recall anything like lmb being referred to in > the rest of the kernel. Heh. It's the OpenFirmware name for a Logical Memory Block. Basically what we use to determine the SECTION_SIZE on powerpc. Probably not the best terminology to use elsewhere in the kernel. -- Dave -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org