From: Johannes Berg <johannes@sipsolutions.net>
To: Stanislaw Gruszka <sgruszka@redhat.com>
Cc: Wey-Yi Guy <wey-yi.w.guy@intel.com>,
"John W. Linville" <linville@tuxdriver.com>,
linux-wireless@vger.kernel.org
Subject: Re: [PATCH 2/6] mac80211: merge ieee80211_scan_work() common code
Date: Mon, 04 Oct 2010 15:02:27 +0200 [thread overview]
Message-ID: <1286197347.3620.26.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <1285934732-16087-2-git-send-email-sgruszka@redhat.com>
On Fri, 2010-10-01 at 14:05 +0200, Stanislaw Gruszka wrote:
> Merge common code using goto instruction. Except less LOC, one of
> the benefit is decrease number of places where function
> ieee80211_scan_completed() is called.
> + int rc = 1;
This shouldn't be necessary, and will only serve to hide warnings if
somebody rearranges this code in the future.
> + bool aborted = true;
I'd prefer also not initialising this here and putting the = true into
all the few places that need it so that we get warnings for new places
that jump to the completed w/o properly setting aborted.
johannes
next prev parent reply other threads:[~2010-10-04 13:02 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-01 12:05 [PATCH 1/6] mac80211: perform scan cancel in hw reset work Stanislaw Gruszka
2010-10-01 12:05 ` [PATCH 2/6] mac80211: merge ieee80211_scan_work() common code Stanislaw Gruszka
2010-10-04 13:02 ` Johannes Berg [this message]
2010-10-04 13:07 ` Johannes Berg
2010-10-01 12:05 ` [PATCH 3/6] mac80211: keep lock when calling __ieee80211_scan_completed() Stanislaw Gruszka
2010-10-04 13:09 ` Johannes Berg
2010-10-04 14:52 ` Stanislaw Gruszka
2010-10-01 12:05 ` [PATCH 4/6] mac80211: assure we also cancel deferred scan request Stanislaw Gruszka
2010-10-04 13:11 ` Johannes Berg
2010-10-04 15:17 ` Stanislaw Gruszka
2010-10-01 12:05 ` [PATCH 5/6] mac80211: do not requeue scan work when not needed Stanislaw Gruszka
2010-10-01 12:05 ` [PATCH 6/6] Revert "iwlwifi: do not perferm force reset while doing scan" Stanislaw Gruszka
2010-10-01 16:11 ` [PATCH 1/6] mac80211: perform scan cancel in hw reset work Johannes Berg
2010-10-01 17:20 ` Luis R. Rodriguez
2010-10-05 9:25 ` Stanislaw Gruszka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1286197347.3620.26.camel@jlt3.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=sgruszka@redhat.com \
--cc=wey-yi.w.guy@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.