Re: [RFC online/offline atoms PATCH 4/4] isigen: create sms and gprs in post_sim

[Marcel Holtmann <marcel@holtmann.org>]

[-- Attachment #1: Type: text/plain, Size: 1234 bytes --]

Hi Pekka,

> ---
>  plugins/isigen.c |   20 ++++++++++----------
>  1 files changed, 10 insertions(+), 10 deletions(-)
> 
> diff --git a/plugins/isigen.c b/plugins/isigen.c
> index db61fdb..d550a34 100644
> --- a/plugins/isigen.c
> +++ b/plugins/isigen.c
> @@ -395,22 +395,29 @@ static void isigen_pre_sim(struct ofono_modem *modem)
>  static void isigen_post_sim(struct ofono_modem *modem)
>  {
>  	struct isi_data *isi = ofono_modem_get_data(modem);
> +	struct ofono_gprs *gprs;
> +	struct ofono_gprs_context *gc;
>  
>  	DBG("(%p) with %s", modem, isi->ifname);
>  
>  	ofono_phonebook_create(isi->modem, 0, "isimodem", isi->idx);
> +	ofono_sms_create(isi->modem, 0, "isimodem", isi->idx);
> +	gprs = ofono_gprs_create(isi->modem, 0, "isimodem", isi->idx);
> +	gc = ofono_gprs_context_create(isi->modem, 0, "isimodem", isi->idx);

what advantage to we have from moving SMS and GPRS atom into the
post_sim state? I am trying to really understand what this is trying to
do and what is the difference of just doing it when in post_online
state.

Are we expecting SMS and GPRS to just bring the modem online if needed
or what is this about? I don't see how useful this could be.

Regards

Marcel