All of lore.kernel.org
 help / color / mirror / Atom feed
From: Liam Girdwood <lrg@slimlogic.co.uk>
To: Dimitris Papastamos <dp@opensource.wolfsonmicro.com>
Cc: alsa-devel@alsa-project.org,
	Mark Brown <broonie@opensource.wolfsonmicro.com>,
	patches@opensource.wolfsonmicro.com
Subject: Re: [PATCH] ASoC: WM8804: Retrieve the device revision and print it
Date: Tue, 05 Oct 2010 17:48:48 +0100	[thread overview]
Message-ID: <1286297328.3111.113.camel@odin> (raw)
In-Reply-To: <1286206139-8851-1-git-send-email-dp@opensource.wolfsonmicro.com>

On Mon, 2010-10-04 at 16:28 +0100, Dimitris Papastamos wrote:
> Be verbose and print out the device revision.
> 
> Signed-off-by: Dimitris Papastamos <dp@opensource.wolfsonmicro.com>
> ---
>  sound/soc/codecs/wm8804.c |    8 ++++++++
>  1 files changed, 8 insertions(+), 0 deletions(-)
> 
> diff --git a/sound/soc/codecs/wm8804.c b/sound/soc/codecs/wm8804.c
> index 2657f5c..642b07c 100644
> --- a/sound/soc/codecs/wm8804.c
> +++ b/sound/soc/codecs/wm8804.c
> @@ -643,6 +643,14 @@ static int wm8804_probe(struct snd_soc_codec *codec)
>  		goto err_reg_enable;
>  	}
>  
> +	ret = snd_soc_read(codec, WM8804_DEVREV);
> +	if (ret < 0) {
> +		dev_err(codec->dev, "Failed to read device revision: %d\n",
> +			ret);
> +		goto err_reg_enable;
> +	}
> +	dev_info(codec->dev, "revision %c\n", ret + 'A');
> +
>  	ret = wm8804_reset(codec);
>  	if (ret < 0) {
>  		dev_err(codec->dev, "Failed to issue reset: %d\n", ret);

Acked-by: Liam Girdwood <lrg@slimlogic.co.uk>
-- 
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk

  reply	other threads:[~2010-10-05 16:48 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-04 15:28 [PATCH] ASoC: WM8804: Retrieve the device revision and print it Dimitris Papastamos
2010-10-05 16:48 ` Liam Girdwood [this message]
2010-10-05 16:58 ` Mark Brown
  -- strict thread matches above, loose matches on Subject: below --
2010-10-04 14:29 Dimitris Papastamos
2010-10-04 15:16 ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1286297328.3111.113.camel@odin \
    --to=lrg@slimlogic.co.uk \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=dp@opensource.wolfsonmicro.com \
    --cc=patches@opensource.wolfsonmicro.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.