From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dimitris Papastamos Subject: Re: ASoC updates for 2.6.37 Date: Wed, 06 Oct 2010 10:25:40 +0100 Message-ID: <1286357140.9697.17.camel@dplaptop> References: <20101005191359.GA23315@opensource.wolfsonmicro.com> <20101006063401.GB17998@sirena.org.uk> <20101006073104.GC17998@sirena.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from opensource2.wolfsonmicro.com (opensource.wolfsonmicro.com [80.75.67.52]) by alsa0.perex.cz (Postfix) with ESMTP id 8ECFD24462 for ; Wed, 6 Oct 2010 11:25:43 +0200 (CEST) In-Reply-To: <20101006073104.GC17998@sirena.org.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: Mark Brown Cc: Takashi Iwai , alsa-devel@alsa-project.org, Liam@alsa-project.org, Girdwood List-Id: alsa-devel@alsa-project.org On Wed, 2010-10-06 at 08:31 +0100, Mark Brown wrote: On Wed, Oct 06, 2010 at 09:10:23AM +0200, Takashi Iwai wrote: > > > If the above difference is intentional, it should be commented > > somewhere. > > Meh, yes. Dimitris, please fix or add a comment as appropriate. > In snd_soc_7_9_spi_write we prepare the tx buffer to be register followed by data packed into 16 bits. In snd_soc_4_12_spi_write the tx buffer is swapped. I'd expect this to be consistent between the two transfers. Thanks, Dimitrios