Re: [PATCH 18/18] KVM test: Add subtest of testing offload by ethtool

[Lucas Meneghel Rodrigues <lmr@redhat.com>]

On Wed, 2010-10-06 at 10:55 -0500, Ryan Harper wrote:
> * pradeep <psuriset@linux.vnet.ibm.com> [2010-10-06 03:57]:
> > On Mon, 27 Sep 2010 18:44:04 -0400
> > Lucas Meneghel Rodrigues <lmr@redhat.com> wrote:
> > 
> > 
> > > +
> > > +    vm = kvm_test_utils.get_living_vm(env, params.get("main_vm"))
> > > +    session = kvm_test_utils.wait_for_login(vm,
> > > +                  timeout=int(params.get("login_timeout", 360)))
> > > +    # Let's just error the test if we identify that there's no
> > > ethtool installed
> > > +    if session.get_command_status("ethtool -h"):
> > > +        raise error.TestError("Command ethtool not installed on
> > > guest")
> > > +    session2 = kvm_test_utils.wait_for_login(vm,
> > > +                  timeout=int(params.get("login_timeout", 360)))
> > > +    mtu = 1514
> > > +    feature_status = {}
> > > +    filename = "/tmp/ethtool.dd"
> > > +    guest_ip = vm.get_address()
> > > +    ethname = kvm_test_utils.get_linux_ifname(session,
> > > vm.get_mac_address(0))
> > > +    supported_features = params.get("supported_features").split()
> > 
> > I guess split this expects input.
> > 
> > 23:48:03 ERROR| Test failed: AttributeError: 'NoneType' object has no
> > attribute 'split'
> 
> That'll need an update to the tests_base.cfg file to ensure the test
> type has that config value set.
> 
> Did the patchset miss updating tests_base.cfg.sample with this one ?

I think pradeep forgot to update tests_base.cfg indeed. It's working
fine for me.