From: Alex Elder <aelder@sgi.com>
To: Christoph Hellwig <hch@lst.de>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH] xfs: fix bogus m_maxagi check in xfs_iget
Date: Thu, 07 Oct 2010 14:22:18 -0500 [thread overview]
Message-ID: <1286479338.2670.26.camel@doink> (raw)
In-Reply-To: <20101006183123.GA2166@lst.de>
On Wed, 2010-10-06 at 14:31 -0400, Christoph Hellwig wrote:
> These days inode64 should only control which AGs we allocate new inodes
> from, while we still try to support reading all existing inodes. To make
> this actually work the check ontop of xfs_iget needs to be relaxed to allow
> inodes in all allocation groups instead of just those that we allow
> allocating inodes from. Note that we can't simply remove the check - it
> prevents us from accessing invalid data when fed invalid inode numbers
> from NFS or bulkstat.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
Looks good.
Reviewed-by: Alex Elder <aelder@sgi.com>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2010-10-07 19:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-06 18:31 [PATCH] xfs: fix bogus m_maxagi check in xfs_iget Christoph Hellwig
2010-10-07 19:22 ` Alex Elder [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1286479338.2670.26.camel@doink \
--to=aelder@sgi.com \
--cc=hch@lst.de \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.