From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vasiliy Kulikov Date: Sun, 10 Oct 2010 17:28:31 +0000 Subject: [PATCH] drivers: mfd: fix off by one error Message-Id: <1286731711-17865-1-git-send-email-segooon@gmail.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: kernel-janitors@vger.kernel.org Cc: Samuel Ortiz , =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= , linux-kernel@vger.kernel.org snprintf() is overflowed iff result is greater or equal than argument "size". Signed-off-by: Vasiliy Kulikov --- Compile tested. drivers/mfd/mc13xxx-core.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/mfd/mc13xxx-core.c b/drivers/mfd/mc13xxx-core.c index 93258ad..cd4d670 100644 --- a/drivers/mfd/mc13xxx-core.c +++ b/drivers/mfd/mc13xxx-core.c @@ -696,7 +696,7 @@ static int mc13xxx_add_subdevice_pdata(struct mc13xxx *mc13xxx, }; /* there is no asnprintf in the kernel :-( */ - if (snprintf(buf, sizeof(buf), format, name) > sizeof(buf)) + if (snprintf(buf, sizeof(buf), format, name) >= sizeof(buf)) return -E2BIG; cell.name = kmemdup(buf, strlen(buf) + 1, GFP_KERNEL); -- 1.7.0.4 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757897Ab0JJR2i (ORCPT ); Sun, 10 Oct 2010 13:28:38 -0400 Received: from mail-ew0-f46.google.com ([209.85.215.46]:38797 "EHLO mail-ew0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756199Ab0JJR2g (ORCPT ); Sun, 10 Oct 2010 13:28:36 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:cc:subject:date:message-id:x-mailer; b=FhF69n14oQSO1AzhPrwrnJwZ+wDlUb6Zojny5eW+UlxrbkqywqBgwG/BVhNy8j/6Ae QdtIYTpUUQx+r1JBud6kqP6ljQMrUzO1bGkcUTGnMpKGzIf6F8aLybVYTIiNvO+zDO71 /lvuDNyx5svNXjS3gLuQP4RRZnx64MnZ2CpKE= From: Vasiliy Kulikov To: kernel-janitors@vger.kernel.org Cc: Samuel Ortiz , =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= , linux-kernel@vger.kernel.org Subject: [PATCH] drivers: mfd: fix off by one error Date: Sun, 10 Oct 2010 21:28:31 +0400 Message-Id: <1286731711-17865-1-git-send-email-segooon@gmail.com> X-Mailer: git-send-email 1.7.0.4 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org snprintf() is overflowed iff result is greater or equal than argument "size". Signed-off-by: Vasiliy Kulikov --- Compile tested. drivers/mfd/mc13xxx-core.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/mfd/mc13xxx-core.c b/drivers/mfd/mc13xxx-core.c index 93258ad..cd4d670 100644 --- a/drivers/mfd/mc13xxx-core.c +++ b/drivers/mfd/mc13xxx-core.c @@ -696,7 +696,7 @@ static int mc13xxx_add_subdevice_pdata(struct mc13xxx *mc13xxx, }; /* there is no asnprintf in the kernel :-( */ - if (snprintf(buf, sizeof(buf), format, name) > sizeof(buf)) + if (snprintf(buf, sizeof(buf), format, name) >= sizeof(buf)) return -E2BIG; cell.name = kmemdup(buf, strlen(buf) + 1, GFP_KERNEL); -- 1.7.0.4