From mboxrd@z Thu Jan 1 00:00:00 1970 From: Liam Girdwood Subject: Re: [patch] ASoC: soc: snprintf() doesn't return negative Date: Mon, 11 Oct 2010 11:07:47 +0100 Message-ID: <1286791667.3306.0.camel@odin> References: <20101011035416.GD5851@bicker> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ww0-f51.google.com (mail-ww0-f51.google.com [74.125.82.51]) by alsa0.perex.cz (Postfix) with ESMTP id 6F38D1038ED for ; Mon, 11 Oct 2010 12:07:50 +0200 (CEST) Received: by wwb28 with SMTP id 28so2829904wwb.20 for ; Mon, 11 Oct 2010 03:07:50 -0700 (PDT) In-Reply-To: <20101011035416.GD5851@bicker> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: Dan Carpenter Cc: alsa-devel@alsa-project.org, Jassi Brar , Takashi Iwai , kernel-janitors@vger.kernel.org, Mark Brown , Peter Ujfalusi List-Id: alsa-devel@alsa-project.org On Mon, 2010-10-11 at 05:54 +0200, Dan Carpenter wrote: > In user space snprintf() returns negative on errors but the kernel > version only returns positives. It could potentially return sizes > larger than the size of the buffer so we should check for that. > > Signed-off-by: Dan Carpenter > Acked-by: Liam Girdwood -- Freelance Developer, SlimLogic Ltd ASoC and Voltage Regulator Maintainer. http://www.slimlogic.co.uk From mboxrd@z Thu Jan 1 00:00:00 1970 From: Liam Girdwood Date: Mon, 11 Oct 2010 10:07:47 +0000 Subject: Re: [patch] ASoC: soc: snprintf() doesn't return negative Message-Id: <1286791667.3306.0.camel@odin> List-Id: References: <20101011035416.GD5851@bicker> In-Reply-To: <20101011035416.GD5851@bicker> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Dan Carpenter Cc: alsa-devel@alsa-project.org, Jassi Brar , Takashi Iwai , kernel-janitors@vger.kernel.org, Mark Brown , Peter Ujfalusi On Mon, 2010-10-11 at 05:54 +0200, Dan Carpenter wrote: > In user space snprintf() returns negative on errors but the kernel > version only returns positives. It could potentially return sizes > larger than the size of the buffer so we should check for that. > > Signed-off-by: Dan Carpenter > Acked-by: Liam Girdwood -- Freelance Developer, SlimLogic Ltd ASoC and Voltage Regulator Maintainer. http://www.slimlogic.co.uk